Skip to content

Using encode_arrow_schema from arrow-rs. #17543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Using encode_arrow_schema from arrow-rs. #17543

merged 1 commit into from
Sep 12, 2025

Conversation

@samueleresca
Copy link
Member

@samueleresca samueleresca commented Sep 12, 2025

Which issue does this PR close?

What changes are included in this PR?

  • Removing the custom encode_arrow_schema implementation.
  • Removing unused dependencies.

Are these changes tested?

Unit test coverage

Are there any user-facing changes?

No

@github-actions github-actions bot added the common Related to common crate label Sep 12, 2025
@samueleresca samueleresca force-pushed the 6916-encode_arrow_schema branch from 1646b05 to 5aaebd6 Compare September 12, 2025 13:47
@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Sep 12, 2025
@samueleresca samueleresca force-pushed the 6916-encode_arrow_schema branch from 5aaebd6 to 70be2c6 Compare September 12, 2025 13:48
@github-actions github-actions bot removed documentation Improvements or additions to documentation development-process Related to development process of DataFusion optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Sep 12, 2025
@samueleresca samueleresca force-pushed the 6916-encode_arrow_schema branch from 70be2c6 to 4659d57 Compare September 12, 2025 13:50
@samueleresca samueleresca marked this pull request as ready for review September 12, 2025 13:50
alamb
alamb approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samueleresca

@alamb alamb merged commit 20f1640 into apache:main Sep 12, 2025
30 checks passed
samueleresca added a commit to samueleresca/datafusion that referenced this pull request Sep 15, 2025
@samueleresca
Using encode_arrow_schema from arrow-rs. (apache#17543)
738cbd4
samueleresca added a commit to samueleresca/datafusion that referenced this pull request Sep 15, 2025
@samueleresca
Using encode_arrow_schema from arrow-rs. (apache#17543)
eef8a3b
alamb pushed a commit that referenced this pull request Sep 15, 2025
@samueleresca
Trying cargo machete to prune unused deps. (#17545)
3f22f8c 
* Trying cargo machete to prune unused deps.

* Using encode_arrow_schema from arrow-rs. (#17543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

common Related to common crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removing ad-hoc implementation of encode_arrow_schema

2 participants

@samueleresca @alamb