Use taiki-e/install-action and binstall in CI #17573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
AdamGS
force-pushed
the
adamg/use-taiki-e-install-action-ci
branch
from
9a92103 to
5a63a6c
Compare
blaginin
approved these changes
Sep 15, 2025
.github/workflows/audit.yml
Outdated
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - name: Install cargo-audit | ||
| run: cargo install cargo-audit | ||
| uses: taiki-e/install-action@v2 |
Collaborator
There was a problem hiding this comment.
should we put the version hash?
Contributor
Author
There was a problem hiding this comment.
sure, give me a second
Collaborator
Contributor
|
It failed when I had it enabled. I somewhat doubt it would run well anyways given the machine constraints |
Collaborator
|
Got it! I think it's working now (and actually uses less resources as tools are not built), so going to merge if that's ok with everyone. I think we can iterate on top (as in adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Should make CI faster. For example currently just installing
cargo-msrvtakes >5 minutes, with this PR its ~4 seconds.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?