Skip to content

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Oct 4, 2025

Which issue does this PR close?

  • Closes #.

Related #17466

Rationale for this change

What changes are included in this PR?

Rename print_schema_tree to tree_string to better reflect the method purpose. The method returns a tree string, and doesn't print anything

Are these changes tested?

Yes

Are there any user-facing changes?

@github-actions github-actions bot added the common Related to common crate label Oct 4, 2025
@comphead
Copy link
Contributor Author

comphead commented Oct 4, 2025

The method was added recently #17459 and not yet in use by users

Copy link
Contributor

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a public function, should we add a re-export via a deprecated method to keep backwards API compatible for a few releases? Since no parameters, etc. changed it seems easy enough to do.

@comphead
Copy link
Contributor Author

comphead commented Oct 5, 2025

Thanks @adriangb it was this release added and not yet announced

@comphead comphead added this pull request to the merge queue Oct 5, 2025
Merged via the queue into apache:main with commit 9e8ec54 Oct 5, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants