Skip to content

Conversation

@hareshkh
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Apache Spark concat has some differences comparing to Datafusion, namely:

  • Supports zero arguments
  • Returns NULL if any of inputs are null

What changes are included in this PR?

3-step approach:
- Compute NULL mask from incoming arguments
- Delegate to DataFusion's concat for the actual concatenation
- Apply NULL mask to the result

Are these changes tested?

Are there any user-facing changes?

* chore: Extend backtrace coverage

* fmt

* part2

* feedback

* clippy

* feat: support Spark `concat`

* clippy

* comments

* test

* doc
@hareshkh hareshkh force-pushed the hareshkh/spark-concat-string branch from d5ca888 to fcfca86 Compare October 17, 2025 12:32
@comphead
Copy link
Contributor

Hey @hareshkh I can do a cherry pick if you think this would work better

@comphead
Copy link
Contributor

Created #18128

@hareshkh
Copy link
Contributor Author

Okay, thanks @comphead. Closing this in favour of #18128 and will link that in the release tracker

@hareshkh hareshkh closed this Oct 17, 2025
@hareshkh hareshkh deleted the hareshkh/spark-concat-string branch October 17, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants