fix: Support Dictionary[Int32, Binary] for bitmap count spark function #18273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2025 22:08
Jefffrey
reviewed
Oct 25, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Do we need to consider other key & value types? Since this only implements for i32 x Binary
Comment on lines
104
to
119
| Dictionary(k, v) if k.as_ref() == &DataType::Int32 && v.as_ref() == &Binary => { | ||
| let dict_array = as_dictionary_array::<Int32Type>(input_array); | ||
| let binary_array = as_binary_array(dict_array.values())?; | ||
|
|
||
| let result: Int64Array = dict_array | ||
| .keys() | ||
| .iter() | ||
| .map(|key| { | ||
| key.and_then(|k| { | ||
| binary_count_ones(Some(binary_array.value(k as usize))) | ||
| }) | ||
| }) | ||
| .collect(); | ||
|
|
||
| Ok(result) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| Dictionary(k, v) if k.as_ref() == &DataType::Int32 && v.as_ref() == &Binary => { | |
| let dict_array = as_dictionary_array::<Int32Type>(input_array); | |
| let binary_array = as_binary_array(dict_array.values())?; | |
| let result: Int64Array = dict_array | |
| .keys() | |
| .iter() | |
| .map(|key| { | |
| key.and_then(|k| { | |
| binary_count_ones(Some(binary_array.value(k as usize))) | |
| }) | |
| }) | |
| .collect(); | |
| Ok(result) | |
| } | |
| Dictionary(k, v) if k.as_ref() == &DataType::Int32 && v.as_ref() == &Binary => { | |
| let dict_array = as_dictionary_array::<Int32Type>(input_array); | |
| let array = dict_array.downcast_dict::<BinaryArray>().unwrap(); | |
| Ok(array | |
| .into_iter() | |
| .map(binary_count_ones) | |
| .collect::<Int64Array>()) | |
| } |
Using TypedDictionaryArray
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed.
| } | ||
|
|
||
| #[test] | ||
| fn test_dictionary_encoded_bitmap_count_invoke() -> Result<()> { |
Contributor
There was a problem hiding this comment.
Could we add this as an SLT instead? Can make use of arrow_cast(value, 'Dictionary(...)') to ensure the values are dictionaries
added 4 commits
October 25, 2025 21:26
Jefffrey
approved these changes
Oct 27, 2025
Contributor
|
Thanks @kazantsev-maksim |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
apache#18273) ## Which issue does this PR close? Closes apache#18058 ## Rationale for this change When adding the bitmap_count function to Comet, we get the following error - org.apache.comet.CometNativeException: Error from DataFusion: bitmap_count expects Binary/BinaryView/FixedSizeBinary/LargeBinary as argument, got Dictionary(Int32, Binary). ## Are these changes tested? Added new UT --------- Co-authored-by: Kazantsev Maksim <mn.kazantsev@gmail.com>
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
apache#18273) ## Which issue does this PR close? Closes apache#18058 ## Rationale for this change When adding the bitmap_count function to Comet, we get the following error - org.apache.comet.CometNativeException: Error from DataFusion: bitmap_count expects Binary/BinaryView/FixedSizeBinary/LargeBinary as argument, got Dictionary(Int32, Binary). ## Are these changes tested? Added new UT --------- Co-authored-by: Kazantsev Maksim <mn.kazantsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #18058
Rationale for this change
When adding the bitmap_count function to Comet, we get the following error - org.apache.comet.CometNativeException: Error from DataFusion: bitmap_count expects Binary/BinaryView/FixedSizeBinary/LargeBinary as argument, got Dictionary(Int32, Binary).
Are these changes tested?
Added new UT