feat: Add new() constructor for CachedParquetFileReader #18575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I largely just scrapped together some sort of test by pulling from existing test code in row_group_filter.rs, just to check that the constructor is hooked up. Happy the change it, if anyone has better ideas to improve it. |
alamb
reviewed
Nov 11, 2025
| use object_store::{memory::InMemory, path::Path, ObjectMeta, ObjectStore}; | ||
|
|
||
| #[tokio::test] | ||
| async fn cached_parquet_file_reader() { |
Contributor
There was a problem hiding this comment.
Instead of a test just to test new, how about changing the existing code to call new() rather than constructing CachedParquetFileReader directly?
Contributor
Author
There was a problem hiding this comment.
Makes sense. It did feel very odd to write a test for it. I was thinking we should protect against removing new(), but I guess there isn't a reason someone would just remove the constructor and go back to building the struct manually in that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
newmethod or constructor #18145Rationale for this change
Allows constructing
CachedParquetFileReader::new()manually, allowing users to create it with a custom object reader (inner) object.What changes are included in this PR?
Adds a simple constructor for
CachedParquetFileReaderAre these changes tested?
Added a test
Are there any user-facing changes?
Yes, new constructor available