Issue 2393: Support glob patterns for files#2394

Merged

tustvold merged 27 commits intoapache:masterfrom timvw:ISSUE-2393

May 5, 2022

+217-14

Commits on May 4, 2022

implement globbing on ObjectStore
timvw
committed
remove unused code
timvw
committed
update list_file_with_suffix to use glob_file
timvw
committed
reworked code such that glob_file matches list_file and glob_file_with_suffix list_file_with_suffix
timvw
committed
rework the way we figure out what the greatest common base path is
timvw
committed
refactor tests on longested_search_path_without_glob_pattern
timvw
committed
added comment on / value
timvw
committed
remove unused use stmt
timvw
committed
rework implementation to find largest common path
timvw
committed
revert accidental/temp changes
timvw
committed
added tests to verify globbing
timvw
committed
find inspiration in glob crate to better deal with windows
timvw
committed
when running on windows, the expected path is slightly different (\ instead of /).
timvw
committed
fixed clippy issue
timvw
committed
added section on checks that are executed during a PR build
timvw
committed
updated section (and script) to make explicit this is about formatting
timvw
committed
replace with simple break
timvw
committed
make filter_suffix not-async as it does not need to be async
timvw
committed
no need to collect
timvw
committed
attempt to make tests more understandable
timvw
committed
actually format the code instead of only verifying
timvw
committed
added test with ** as glob pattern as well
timvw
committed
remove changes related to code formatting
timvw
committed
remove unneeded empty line
timvw
committed
run cargo fmt
timvw
committed
Update data-access/src/object_store/mod.rs

timvw
and
tustvold
authored
use try_filter as suggested in pr review
timvw
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 2393: Support glob patterns for files#2394

Commits on May 4, 2022

implement globbing on ObjectStore

remove unused code

update list_file_with_suffix to use glob_file

reworked code such that glob_file matches list_file and glob_file_with_suffix list_file_with_suffix

rework the way we figure out what the greatest common base path is

refactor tests on longested_search_path_without_glob_pattern

added comment on / value

remove unused use stmt

rework implementation to find largest common path

revert accidental/temp changes

added tests to verify globbing

find inspiration in glob crate to better deal with windows

when running on windows, the expected path is slightly different (\ instead of /).

fixed clippy issue

added section on checks that are executed during a PR build

updated section (and script) to make explicit this is about formatting

replace with simple break

make filter_suffix not-async as it does not need to be async

no need to collect

attempt to make tests more understandable

actually format the code instead of only verifying

added test with ** as glob pattern as well

remove changes related to code formatting

remove unneeded empty line

run cargo fmt

Update data-access/src/object_store/mod.rs

use try_filter as suggested in pr review