Make ConfigOptions easier to work with #3909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/sharable_config
branch
from
0544236 to
92d5685
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #3885
Which issue does this PR close?
Resolves #3886
Related to #3887
Rationale for this change
see #3886
Note I chose to keep the
Arcoutside so it stayed clear thatConfigOptionswas shared in many placesWhat changes are included in this PR?
Changes:
ConfigOptionshave "interior mutability" (aka move the lock inside) rather than at CallSitesAre there any user-facing changes?
API for ConfigOptions has changed