-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use requirements.txt to formalize python deps #484
Conversation
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 75.95% 75.95%
=======================================
Files 154 154
Lines 26349 26349
=======================================
Hits 20014 20014
Misses 6335 6335 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Great to see pip-tools being used :)
What do you think about adding to the README how to update test dependencies? Something like
To change test dependencies, change the
requirements.in
and run# change requirements.in pip install pip-tools pip-compile --generate-hashes
To update dependencies, run
pip-compile update
More details here
Personally I lean towards using poetry but that demands changes to publishing procedures as well - what do you think of that? |
I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a AFAI understand this PR is only concerned with the dependencies used for testing. |
i meant the format for defining the project (the poetry way), but you are right this is probably non-related to this PR. |
|
68bd698
to
dfef5af
Compare
Which issue does this PR close?
Closes #504.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?