Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warnings in tests when compiling without default features #489

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 3, 2021

When testing with

cargo test -p datafusion --no-default-features   -- pruning

I get this warning:

warning: unused import: `ListArray`
    --> datafusion/src/physical_plan/functions.rs:1278:25
     |
1278 |             Int32Array, ListArray, StringArray, UInt32Array, UInt64Array,
     |                         ^^^^^^^^^
     |
     = note: `#[warn(unused_imports)]` on by default

Because the test that uses it is not being compiled without the default features.

Thus move the use to the tests that need them.

@codecov-commenter
Copy link

Codecov Report

Merging #489 (ef38b41) into master (33ff660) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   75.80%   75.80%           
=======================================
  Files         153      153           
  Lines       25924    25924           
=======================================
  Hits        19652    19652           
  Misses       6272     6272           
Impacted Files Coverage Δ
datafusion/src/physical_plan/functions.rs 92.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ff660...ef38b41. Read the comment docs.

@alamb alamb merged commit 28b0dad into apache:master Jun 3, 2021
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 30, 2021
@alamb alamb deleted the alamb/fix_warning branch October 6, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants