Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant into_iter() calls #527

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 10, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

remove redundant into_iter calls because Vec<Result<_>> can automatically be transposed to Result<Vec<_>> - there is no need for additional into_iter calls

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title remove redundant into_iter() calls remove redundant into_iter() calls Jun 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #527 (7792c6c) into master (d5bca0e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         157      157           
  Lines       26990    26990           
=======================================
  Hits        20521    20521           
  Misses       6469     6469           
Impacted Files Coverage Δ
...sta/rust/core/src/serde/logical_plan/from_proto.rs 35.20% <ø> (ø)
datafusion/src/physical_plan/windows.rs 86.22% <ø> (ø)
datafusion/src/sql/planner.rs 84.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bca0e...7792c6c. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jun 10, 2021

I am surprised Clippy didn't complain about this ;)

@alamb alamb merged commit 5c88450 into apache:master Jun 10, 2021
@jimexist jimexist deleted the remove-redundant-into-iter branch June 10, 2021 15:17
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants