-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests in parquet.rs
to sqllogictest
#8560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hiltontj -- this looks great. I had a few small comments, but otherwise 👍
The only test remaining that has not been ported over is #[ignore = "Test ignored, will be enabled as part of the nested Parquet reader"] I am not sure if the nested Parquet reader is ready and whether or not it is worth porting this over yet. |
I think it could be ported over but doing so is tricky -- I'll give it a whirl and see if I can make it happen as a follow on PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @hiltontj -- this looks great to me. Great first contribution 🏆
|
Much appreciated, thank you for the guidance. These |
https://github.com/apache/arrow-datafusion/actions/runs/7256262186/job/19796000984?pr=8560 seems to have failed for infrastructure reasons, so merging this PR in 🚀 |
Which issue does this PR close?
Closes #8206.
Rationale for this change
See #6195.
What changes are included in this PR?
parquet.slt
to the sqllogictest suitedatafusion/code/tests/sql/parquet.rs
intoparquet.slt
:parquet_query
parquet_with_sort_order_specified
(see discussion)fixed_size_binary_columns
window_fn_timestamp_tz
parquet_single_nan_schema
parquet_list_columns
(original test is currently ignored, to be enabled with nested Parquet reader)parquet_query_with_max_min
Are these changes tested?
Yes
Are there any user-facing changes?
No