fix release for nginx not package config files, eg: zookeeper.properties #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good job I'm a little confused about missing common.properties in dolphinscheduler-common module ? |
|
thanks for your first contribution, if you need help, please contact dev@dolphinscheduler.apache.org or wechat(510570367), when added, please tell your github id |
|
|
davidzollo
approved these changes
Jun 25, 2020
Co-authored-by: mzjnumber1@163.com <mzjnumber1@163.com>
* fix test mock error * fix test mock error
|
Kudos, SonarCloud Quality Gate passed!
|
lenboo
pushed a commit
that referenced
this pull request
Jun 30, 2020
…ies (#3041) * fix release for nginx bug * add state (#3040) Co-authored-by: mzjnumber1@163.com <mzjnumber1@163.com> * [BUG_FIX]fix multi-threaded tests error. (#3044) * fix test mock error * fix test mock error Co-authored-by: muzhongjiang <mu_zhongjiang@163.com> Co-authored-by: mzjnumber1@163.com <mzjnumber1@163.com> Co-authored-by: CalvinKirs <acm_master@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)