Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-3558][API] Improve DataSourceServiceTest.java #3579

Merged
merged 9 commits into from
Aug 24, 2020
Merged

[Improvement-3558][API] Improve DataSourceServiceTest.java #3579

merged 9 commits into from
Aug 24, 2020

Conversation

yy0812
Copy link
Contributor

@yy0812 yy0812 commented Aug 24, 2020

  1. Improvement DataSourceServiceTest [Test][api] Improvement DataSourceServiceTest #3558
  2. Get rid of some useless arguments to functions in the DataSourceService class

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2020 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

46.7% 46.7% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo linked an issue Aug 24, 2020 that may be closed by this pull request
[Test][api] Improvement DataSourceServiceTest #3558
Closed
davidzollo
davidzollo approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo merged commit 78eb07b into apache:dev Aug 24, 2020
@davidzollo davidzollo added this to the 1.4.0 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

[Test][api] Improvement DataSourceServiceTest
2 participants
@yy0812 @davidzollo