Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][server] WATERDROP task plug-in optimization in switch case code cleaning. #3652

Merged
merged 6 commits into from
Sep 14, 2020

Conversation

zhuangchong
Copy link
Contributor

@zhuangchong zhuangchong commented Sep 3, 2020

#3383

What is the purpose of the pull request
[server] WATERDROP task plug-in optimization in switch case code cleaning.

Brief change log
Clean up duplicate code

Verify this pull request
This pull request is code cleanup without any test coverage.

@codecov-commenter
Copy link

Codecov Report

Merging #3652 into dev will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3652      +/-   ##
============================================
- Coverage     39.16%   39.14%   -0.02%     
+ Complexity     2831     2827       -4     
============================================
  Files           456      456              
  Lines         21629    21627       -2     
  Branches       2623     2623              
============================================
- Hits           8470     8465       -5     
+ Misses        12371    12370       -1     
- Partials        788      792       +4     
Impacted Files Coverage Δ Complexity Δ
...hinscheduler/common/utils/TaskParametersUtils.java 66.66% <ø> (+3.03%) 11.00 <0.00> (ø)
...lphinscheduler/server/worker/task/TaskManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 66.15% <0.00%> (-3.08%) 13.00% <0.00%> (-1.00%)
...dolphinscheduler/remote/future/ResponseFuture.java 79.66% <0.00%> (-1.70%) 17.00% <0.00%> (-1.00%)
...eduler/server/worker/runner/TaskExecuteThread.java 54.83% <0.00%> (-0.81%) 12.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac4ed94...0631f51. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@yangyichao-mango yangyichao-mango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangchong
Copy link
Contributor Author

@dailidong @qiaozhanwei done. Please help to review.

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants