From e1675bbc3ac21f0bb848e9c35bf0140a0d98eaa1 Mon Sep 17 00:00:00 2001 From: nanfeng1999 Date: Mon, 18 Dec 2023 10:48:30 +0800 Subject: [PATCH] add block columns size dcheck --- be/src/vec/core/block.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/be/src/vec/core/block.cpp b/be/src/vec/core/block.cpp index a7965d03ce3e25..544a558afc01ba 100644 --- a/be/src/vec/core/block.cpp +++ b/be/src/vec/core/block.cpp @@ -584,7 +584,9 @@ MutableColumns Block::mutate_columns() { } void Block::set_columns(MutableColumns&& columns) { - /// TODO: assert if |columns| doesn't match |data|! + DCHECK_GE(columns.size(), data.size()) + << fmt::format("Invalid size of columns, columns size: {}, data size: {}", + columns.size(), data.size()); size_t num_columns = data.size(); for (size_t i = 0; i < num_columns; ++i) { data[i].column = std::move(columns[i]); @@ -592,7 +594,9 @@ void Block::set_columns(MutableColumns&& columns) { } void Block::set_columns(const Columns& columns) { - /// TODO: assert if |columns| doesn't match |data|! + DCHECK_GE(columns.size(), data.size()) + << fmt::format("Invalid size of columns, columns size: {}, data size: {}", + columns.size(), data.size()); size_t num_columns = data.size(); for (size_t i = 0; i < num_columns; ++i) { data[i].column = columns[i];