Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](routine-load) fix consumer hang when kafka exception causing can not query #33492

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Apr 10, 2024

Proposed changes

The heavy thread pool is occupied by query_watermark_offsets when Kafka exception occurs, making query can not be executed, according confluentinc/librdkafka#4460, update thirdparty with a patch.

Issue Number: close #33459

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Apr 10, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.62% (8891/24959)
Line Coverage: 27.35% (73049/267137)
Region Coverage: 26.51% (37750/142391)
Branch Coverage: 23.32% (19241/82524)
Coverage Report: http://coverage.selectdb-in.cc/coverage/651b92dd25b6f5b7ec3a56cd6608cb3802960592_651b92dd25b6f5b7ec3a56cd6608cb3802960592/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 05467d3 into apache:master Apr 12, 2024
27 of 31 checks passed
yiguolei pushed a commit that referenced this pull request Apr 12, 2024
yiguolei pushed a commit that referenced this pull request Apr 13, 2024
yiguolei pushed a commit that referenced this pull request Apr 13, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 15, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2024
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.9-merged dev/2.1.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Problem with Kafka cluster causing Doris to be unable to query
6 participants