Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](orc-reader) Fix StringRef nullptr data by add checking string_values empty. #42061 #42169

Conversation

morningman
Copy link
Contributor

cherry pick from #42061

…alues empty. (apache#42061)

## Proposed changes

Added solution to apache#40857, fix StringRef nullptr data by add checking
string_values empty in orc reader.
@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@doris-robot
Copy link

TPC-H: Total hot run time: 40077 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56a65c7ba0ead07cb43b07d4cea9b3c25c443a9a, data reload: false

------ Round 1 ----------------------------------
q1	17601	7293	7239	7239
q2	2052	149	149	149
q3	10739	1077	1106	1077
q4	10545	702	669	669
q5	7723	2818	2813	2813
q6	233	144	147	144
q7	999	633	612	612
q8	9572	1890	1966	1890
q9	8116	6337	6365	6337
q10	6978	2285	2290	2285
q11	436	236	242	236
q12	413	209	215	209
q13	17772	2930	2916	2916
q14	236	207	218	207
q15	553	510	509	509
q16	665	592	601	592
q17	947	562	534	534
q18	7151	6510	6542	6510
q19	1358	903	945	903
q20	585	277	267	267
q21	4057	3122	3015	3015
q22	1062	964	969	964
Total cold run time: 109793 ms
Total hot run time: 40077 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7288	7209	7234	7209
q2	319	228	228	228
q3	2819	2862	2860	2860
q4	2020	1706	1776	1706
q5	5617	5655	5691	5655
q6	225	143	141	141
q7	2236	1780	1798	1780
q8	3298	3468	3481	3468
q9	8623	8824	8812	8812
q10	3513	3487	3506	3487
q11	590	485	480	480
q12	809	605	584	584
q13	15708	3190	3135	3135
q14	299	267	262	262
q15	565	533	522	522
q16	702	662	653	653
q17	1806	1617	1596	1596
q18	8108	7747	7637	7637
q19	3601	1533	1535	1533
q20	2074	1865	1861	1861
q21	5349	5196	5122	5122
q22	1091	1041	1024	1024
Total cold run time: 76660 ms
Total hot run time: 59755 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193316 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56a65c7ba0ead07cb43b07d4cea9b3c25c443a9a, data reload: false

query1	1257	902	849	849
query2	6262	2077	2038	2038
query3	10816	3936	3784	3784
query4	62604	27283	23409	23409
query5	5146	461	453	453
query6	381	167	163	163
query7	5369	322	298	298
query8	273	199	208	199
query9	7884	2674	2642	2642
query10	463	290	267	267
query11	16863	15095	15573	15095
query12	156	102	103	102
query13	1395	480	462	462
query14	10021	7450	6800	6800
query15	219	171	174	171
query16	6976	471	479	471
query17	1113	567	588	567
query18	1465	320	321	320
query19	202	150	151	150
query20	126	112	109	109
query21	204	103	102	102
query22	4525	4570	4579	4570
query23	34779	33683	33792	33683
query24	6016	2852	2826	2826
query25	510	412	420	412
query26	641	159	161	159
query27	1621	307	299	299
query28	4239	2495	2484	2484
query29	666	428	429	428
query30	243	149	167	149
query31	991	782	812	782
query32	71	54	53	53
query33	389	282	291	282
query34	898	517	480	480
query35	873	732	747	732
query36	1072	919	932	919
query37	145	87	89	87
query38	4003	3944	3948	3944
query39	1484	1426	1422	1422
query40	203	100	104	100
query41	47	43	41	41
query42	123	96	97	96
query43	524	481	493	481
query44	1119	783	772	772
query45	196	166	160	160
query46	1138	714	722	714
query47	1890	1830	1825	1825
query48	416	357	346	346
query49	690	398	390	390
query50	810	398	399	398
query51	7032	6987	6869	6869
query52	94	92	87	87
query53	253	178	184	178
query54	561	453	439	439
query55	77	79	75	75
query56	272	250	247	247
query57	1237	1138	1119	1119
query58	224	221	234	221
query59	3256	2977	2831	2831
query60	283	265	272	265
query61	126	97	98	97
query62	781	664	661	661
query63	211	178	179	178
query64	1292	642	613	613
query65	3230	3156	3134	3134
query66	650	299	298	298
query67	15826	15419	15144	15144
query68	3394	553	544	544
query69	733	281	301	281
query70	1145	1084	1104	1084
query71	506	258	281	258
query72	8194	3901	4003	3901
query73	772	335	330	330
query74	10484	8901	8870	8870
query75	4957	2640	2671	2640
query76	3922	822	974	822
query77	816	298	309	298
query78	10071	9284	9116	9116
query79	3907	583	588	583
query80	3250	449	436	436
query81	594	240	242	240
query82	889	138	138	138
query83	316	139	133	133
query84	301	78	76	76
query85	1306	308	282	282
query86	416	287	275	275
query87	4535	4184	4166	4166
query88	4907	2380	2374	2374
query89	419	287	285	285
query90	2271	187	183	183
query91	148	105	105	105
query92	61	48	46	46
query93	5397	536	527	527
query94	1182	304	286	286
query95	346	244	241	241
query96	627	287	277	277
query97	3370	3111	3113	3111
query98	225	196	189	189
query99	1791	1278	1284	1278
Total cold run time: 326174 ms
Total hot run time: 193316 ms

@morningman morningman merged commit ddaf450 into apache:branch-3.0 Oct 21, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants