[feature] (vec) instead of converting line to src tuple for stream load in vectorized. #9314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiepengcheng01
force-pushed
the
vec-load
branch
from
9548478 to
efbf588
Compare
HappenLee
reviewed
May 2, 2022
| RETURN_IF_ERROR(ctx->prepare(_state, *_row_desc.get(), _mem_tracker)); | ||
| RETURN_IF_ERROR(ctx->open(_state)); | ||
| _dest_vexpr_ctx.emplace_back(ctx); | ||
| } |
be/src/exec/broker_scanner.cpp
Outdated
| if (range.__isset.num_of_columns_from_file) { | ||
| fill_slots_of_columns_from_path(range.num_of_columns_from_file, columns_from_path); | ||
| fill_slots_of_columns_from_path(range.num_of_columns_from_file, range.columns_from_path); | ||
| } | ||
|
|
||
| _success = true; |
There was a problem hiding this comment.
in function line_split_to_values have set the _success，not need set here.
|
|
||
| RETURN_IF_ERROR(VExprContext::filter_block(_vconjunct_ctx_ptr, block.get(), | ||
| _tuple_desc->slots().size())); | ||
| _mutable_block->add_rows(block.get(), begin, row_add); |
There was a problem hiding this comment.
here must have a copy here. should opt to skip the copy operation. if _mutable_block.size() + block.size() < batch_size to do merge. else directly return the block, do not copy here
| } | ||
| auto output_block = _mutable_block->to_block(); | ||
| std::shared_ptr<vectorized::Block> block_ptr(new vectorized::Block()); | ||
| block_ptr->swap(std::move(output_block)); |
There was a problem hiding this comment.
block_ptr->swap(_mutable_block->to_block());
| if (_scan_finished.load()) { | ||
| return Status::OK(); | ||
| } | ||
| std::shared_ptr<vectorized::Block> block(new vectorized::Block()); |
There was a problem hiding this comment.
why here is shared_ptr ? not the unique_ptr?
HappenLee
reviewed
May 2, 2022
be/src/vec/exec/vbroker_scanner.cpp
Outdated
| SCOPED_TIMER(_read_timer); | ||
|
|
||
| const int batch_size = _state->batch_size(); | ||
| std::shared_ptr<vectorized::Block> tmp_block(std::make_shared<Block>()); |
There was a problem hiding this comment.
why define tmp_block here ？ should in _fill_dest_block.
xiepengcheng01
force-pushed
the
vec-load
branch
2 times, most recently
from
cacbcbe to
7190796
Compare
HappenLee
reviewed
May 6, 2022
| _queue_writer_cond.notify_all(); | ||
|
|
||
| // All scanner has been finished, and all cached batch has been read | ||
| if (scanner_block == nullptr || scanner_block.get() == nullptr) { |
There was a problem hiding this comment.
scanner_block == nullptr || scanner_block.get() == nullptr only need one
| // notify one scanner | ||
| _queue_writer_cond.notify_one(); | ||
|
|
||
| if (_mutable_block.get() == nullptr) { |
There was a problem hiding this comment.
unlikely, should move the line to up
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
May 9, 2022
…ad in vectorized. (apache#9314) Co-authored-by: xiepengcheng01 <xiepengcheng01@xafj-palo-rpm64.xafj.baidu.com>
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
May 13, 2022
…ad in vectorized. (apache#9314) Co-authored-by: xiepengcheng01 <xiepengcheng01@xafj-palo-rpm64.xafj.baidu.com>
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
…ad in vectorized. (apache#9314) Co-authored-by: xiepengcheng01 <xiepengcheng01@xafj-palo-rpm64.xafj.baidu.com>
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
…ad in vectorized. (apache#9314) Co-authored-by: xiepengcheng01 <xiepengcheng01@xafj-palo-rpm64.xafj.baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support stream load in vectorized instead of converting line to src tuple for vbroker scanner.
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...