[Bug] Missing error tablet list when close_wait return error #9418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengxiangyu
changed the title
pengxiangyu
changed the title
pengxiangyu
changed the title
morningman
previously approved these changes
May 7, 2022
be/src/olap/delta_writer.cpp
Outdated
| @@ -321,7 +322,13 @@ Status DeltaWriter::close_wait(google::protobuf::RepeatedPtrField<PTabletInfo>* | |||
| } | |||
|
|
|||
| // return error if previous flush failed | |||
| RETURN_NOT_OK(_flush_token->wait()); | |||
| Status s = Status::OK(); | |||
There was a problem hiding this comment.
Suggested change
| Status s = Status::OK(); | |
| Status s = _flush_token->wait(); | |
| if (!s.ok()) { | |
| ... | |
| } |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
added
kind/fix
github-actions
bot
removed
the
approved
morningman
previously approved these changes
May 7, 2022
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
removed
the
approved
morningman
approved these changes
May 7, 2022
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morningman
added
dev/merged-1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
May 16, 2022
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9417
Problem Summary:
In function close_wait() of delta_writer.cpp, if _flush_token->wait() return an error, it will not be returned to front.
Because in PInternalServiceImpl::tablet_writer_add_batch, _exec_env->load_channel_mgr()->add_batch(*request, response); will not return an error, but only return error_tablets. However error_tablets in close_wait() is not returned.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...