[FLINK-34413] Remove HBase 1.x connector files and deps #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tan-JiaLiang if you have some time can you PTAL? |
MartijnVisser
requested changes
Mar 4, 2024
There was a problem hiding this comment.
@ferenc-csaky I found one more inclusion of hbase-1.4 but otherwise this looks good. If you can fix that, I'll merge it afterwards
Tan-JiaLiang
suggested changes
Mar 6, 2024
There was a problem hiding this comment.
@ferenc-csaky Thanks for driving this, almost looks good, added a minor comment.
ferenc-csaky
force-pushed
the
FLINK-34413
branch
from
a520087 to
af27566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the as minimum change as possible approach. Some pinned/excluded dependencies probably can be cleaned up, but I'd rather do that separately to not involve too many changes.
List of relevant changes:
flink-connector-hbase-base, cause the 2.xhbase-clientdoes not carry it in any form andHBaseConfigLoadingTestfailed with Guava class not found.flink-connector-hbase-basedep matrix, the trasitively included deps offlink-connector-hbase-2.2changed a bit.