From 84c4bb443bdea01f310fc5b940fac9f6a50411c1 Mon Sep 17 00:00:00 2001 From: Fabian Hueske Date: Thu, 18 Oct 2018 10:13:04 +0200 Subject: [PATCH 1/3] [hotfix] Add Review Progress section to PR description template. --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a017732dc525a..79b42496d0bbe 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -70,3 +70,15 @@ This change added tests and can be verified as follows: - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) + +---- + +# Review Progress + +* [ ] 1. The contribution is well-described. +* [ ] 2. There is consensus that the contribution should go into to Flink. +* [ ] 3. [Does not need specific attention | Needs specific attention for X | Has attention for X by Y] +* [ ] 4. The architectural approach is sound. +* [ ] 5. Overall code quality is good. + +Please see the [Pull Request Review Guide](https://flink.apache.org/reviewing-prs.html) if you have questions about the review process. \ No newline at end of file From 4f1076360614ab6e5f687bd8a2b43ed7d07276a5 Mon Sep 17 00:00:00 2001 From: Fabian Hueske Date: Thu, 18 Oct 2018 11:23:33 +0200 Subject: [PATCH 2/3] Address comment --- .github/PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 79b42496d0bbe..0897fc0b49951 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -73,7 +73,9 @@ This change added tests and can be verified as follows: ---- -# Review Progress +# Review Progress + +**NOTE: THE REVIEW PROGRESS MUST ONLY BE UPDATED BY AN APACHE FLINK COMMITTER!** * [ ] 1. The contribution is well-described. * [ ] 2. There is consensus that the contribution should go into to Flink. From 8ecc521f72ac4b4c0b3868355803c6ffe5cd4ddd Mon Sep 17 00:00:00 2001 From: Fabian Hueske Date: Tue, 22 Jan 2019 15:12:15 +0100 Subject: [PATCH 3/3] Remove line about committers. --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0897fc0b49951..549ddd4c1f93b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -73,9 +73,7 @@ This change added tests and can be verified as follows: ---- -# Review Progress - -**NOTE: THE REVIEW PROGRESS MUST ONLY BE UPDATED BY AN APACHE FLINK COMMITTER!** +# Review Progress * [ ] 1. The contribution is well-described. * [ ] 2. There is consensus that the contribution should go into to Flink. @@ -83,4 +81,4 @@ This change added tests and can be verified as follows: * [ ] 4. The architectural approach is sound. * [ ] 5. Overall code quality is good. -Please see the [Pull Request Review Guide](https://flink.apache.org/reviewing-prs.html) if you have questions about the review process. \ No newline at end of file +Please see the [Pull Request Review Guide](https://flink.apache.org/reviewing-prs.html) if you have questions about the review process.