Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5582] improvement(hadoop3-filesystem): Remove configuration fs.gvfs.filesystem.providers from GVFS client. #5634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuqi1129
Copy link
Contributor

What changes were proposed in this pull request?

Configuration fs.gvfs.filesystem.providers is redundant, so we'd better remove this configuation.

Why are the changes needed?

This configuration is redundant.
Fix: #5582

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Existing tests.

@yuqi1129 yuqi1129 self-assigned this Nov 20, 2024
if (resultMap.containsKey(fileSystemProvider.scheme())) {
throw new UnsupportedOperationException(
String.format(
"File system provider: '%s' with scheme '%s' already exists in the use provider list "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"File system provider: '%s' with scheme '%s' already exists in the use provider list "
"File system provider: '%s' with scheme '%s' already exists in the provider list, "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

throw new UnsupportedOperationException(
String.format(
"File system provider: '%s' with scheme '%s' already exists in the use provider list "
+ "Please make sure the file system provider scheme is unique.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ "Please make sure the file system provider scheme is unique.",
+ "please make sure the filesystem provider scheme is unique.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Remove fs.gvfs.filesystem.providers from GVFS client.
2 participants