HDDS-1657. Fix parallelStream usage in volume and key native acl. Contributed by Ajay Kumar. (#926)

Author: ajayydv

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java

@@ -1377,7 +1377,7 @@ public boolean setAcl(OzoneObj obj, List<OzoneAcl> acls) throws IOException {
     SetAclRequest.Builder builder = SetAclRequest.newBuilder()
         .setObj(OzoneObj.toProtobuf(obj));
 
-    acls.parallelStream().forEach(a -> builder.addAcl(OzoneAcl.toProtobuf(a)));
+    acls.forEach(a -> builder.addAcl(OzoneAcl.toProtobuf(a)));
 
     OMRequest omRequest = createOMRequest(Type.SetAcl)
         .setSetAclRequest(builder.build())

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java

@@ -2291,9 +2291,13 @@ private void validateOzoneAcl(OzoneObj ozObj) throws IOException {
     expectedAcls.forEach(a -> assertTrue(finalNewAcls.contains(a)));
 
     // Reset acl's.
-    store.setAcl(ozObj, new ArrayList<>());
+    OzoneAcl ua = new OzoneAcl(ACLIdentityType.USER, "userx", ACLType.READ_ACL);
+    OzoneAcl ug = new OzoneAcl(ACLIdentityType.GROUP, "userx", ACLType.ALL);
+    store.setAcl(ozObj, Arrays.asList(ua, ug));
     newAcls = store.getAcl(ozObj);
-    assertTrue(newAcls.size() == 0);
+    assertTrue(newAcls.size() == 2);
+    assertTrue(newAcls.contains(ua));
+    assertTrue(newAcls.contains(ug));
   }
 
   private void writeKey(String key1, OzoneBucket bucket) throws IOException {

hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java

@@ -411,8 +411,7 @@ private RemoveAclResponse removeAcl(RemoveAclRequest req)
 
   private SetAclResponse setAcl(SetAclRequest req) throws IOException {
     List<OzoneAcl> ozoneAcl = new ArrayList<>();
-    req.getAclList().parallelStream().forEach(a ->
-        ozoneAcl.add(OzoneAcl.fromProtobuf(a)));
+    req.getAclList().forEach(a -> ozoneAcl.add(OzoneAcl.fromProtobuf(a)));
     boolean response = impl.setAcl(OzoneObjInfo.fromProtobuf(req.getObj()),
         ozoneAcl);
     return SetAclResponse.newBuilder().setResponse(response).build();