Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-8246 winutils - fix failure to retrieve disk and network perf co… #458

Closed
wants to merge 1 commit into from

Commits on Jan 7, 2019

  1. YARN-8246 winutils - fix failure to retrieve disk and network perf co…

    …unters on localized windows installlation
    
    PdhAddCounter expects performance counter path to be in the same language than the windows installation.
    With current code, the calls to PdhAddCounter will fail with error 0xc0000bb8 (PDH_CSTATUS_NO_OBJECT)
    on non-english windows installation.
    
    The solution is to use PdhAddEnglishCounter function instead
    https://docs.microsoft.com/en-us/windows/desktop/api/pdh/nf-pdh-pdhaddenglishcounterw
    
    "This function provides a language-neutral way to add performance counters to the query"
    pgoron committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    0d3066a View commit details
    Browse the repository at this point in the history