Skip to content

HADOOP-19572. [ABFS][BugFix][Backport 3.4] Empty Page Issue on Subsequent ListBlob call with NextMarker #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

HADOOP-19572. [ABFS][BugFix][Backport 3.4] Empty Page Issue on Subsequent ListBlob call with NextMarker #7704

merged 1 commit into from
May 22, 2025

Conversation

@anujmodi2021
Copy link
Contributor

@anujmodi2021 anujmodi2021 commented May 22, 2025

Description of PR

We came across a new behavior from the server where a ListBlob call can return an empty list even after returning a next marker(continuation token) from a previous list call.
This is to handle that case and do not imply listing to be incomplete.

How was this patch tested?

Existing Test Suite ran, and new tests are added.

@anujmodi2021
HADOOP-19572. [ABFS][BugFix] Empty Page Issue on Subsequent ListBlob …
ddc2dfe 
…call with NextMarker (apache#7698)

Contributed by Anuj Modi
Reviewed by Anmol Asrani, Manish Bhatt, Manika Joshi

Signed off by Anuj Mod<anujmodi@apache.org>
@hadoop-yetus
Copy link

hadoop-yetus commented May 22, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 7 new or modified test files.
_ branch-3.4 Compile Tests _
+1 💚 mvninstall 21m 42s branch-3.4 passed
+1 💚 compile 0m 26s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 24s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 22s branch-3.4 passed
+1 💚 mvnsite 0m 28s branch-3.4 passed
+1 💚 javadoc 0m 28s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 21s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 45s branch-3.4 passed
+1 💚 shadedclient 19m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 20s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 18s the patch passed
+1 💚 compile 0m 15s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 10s the patch passed
+1 💚 mvnsite 0m 19s the patch passed
+1 💚 javadoc 0m 15s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 19s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 42s the patch passed
+1 💚 shadedclient 19m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 1s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
76m 34s
Subsystem Report/Notes
Docker ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7704/1/artifact/out/Dockerfile
GITHUB PR #7704
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 78910674890f 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / ddc2dfe
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7704/1/testReport/
Max. process+thread count 612 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7704/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@anujmodi2021
Copy link
Contributor Author

anujmodi2021 commented May 22, 2025

:::: AGGREGATED TEST RESULT ::::

============================================================
HNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 826, Failures: 0, Errors: 0, Skipped: 177
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
HNS-SharedKey-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 826, Failures: 0, Errors: 0, Skipped: 126
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 10

============================================================
NonHNS-SharedKey-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 377
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 11

============================================================
AppendBlob-HNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 826, Failures: 0, Errors: 0, Skipped: 188
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 56
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-SharedKey-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 284
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 11

============================================================
NonHNS-OAuth-DFS

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 382
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
NonHNS-OAuth-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 300
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
AppendBlob-NonHNS-OAuth-Blob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 320
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 51
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
HNS-Oauth-DFS-IngressBlob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 826, Failures: 0, Errors: 0, Skipped: 310
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-OAuth-DFS-IngressBlob

[WARNING] Tests run: 177, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 810, Failures: 0, Errors: 0, Skipped: 380
[WARNING] Tests run: 182, Failures: 0, Errors: 0, Skipped: 33
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

Time taken: 168 mins 34 secs.

@anujmodi2021 anujmodi2021 merged commit 4e14cd9 into apache:branch-3.4 May 22, 2025
3 checks passed
@anujmodi2021
Copy link
Contributor Author

anujmodi2021 commented May 22, 2025

Hi @steveloughran @ahmarsuhail
I see that a branch for 3.4.2 is already cut from 3.4.
Kindly request you to please allow us getting this change picked up in 3.4.2 as well.
This is a critical bug on listing API.

Thanks

@anujmodi2021 anujmodi2021 deleted the branch-3.4_HADOOP-19572 branch June 10, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anujmodi2021 @hadoop-yetus