From 7d4275b07466cd7be35a3bf92386d91239ba964a Mon Sep 17 00:00:00 2001 From: smajeti22-dev Date: Tue, 21 Oct 2025 11:27:13 +0530 Subject: [PATCH 1/2] HDFS-17847 OIV exits with code 0 (success) even when the output file is incomplete --- .../hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java index fe31872304ebf..89edc1144a760 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java @@ -265,6 +265,10 @@ public static int run(String[] args) throws Exception { printUsage(); return -1; } + if ((out != null) && out.checkError()) { + System.err.println("CRITICAL FAILURE: PrintStream reported a write error (e.g., Disk Full)."); + return -1; + } return 0; } catch (EOFException e) { System.err.println("Input file ended unexpectedly. Exiting"); From c766b1e766fc230d73375745b377707f2f46d2e9 Mon Sep 17 00:00:00 2001 From: Srinivasu Majeti Date: Thu, 23 Oct 2025 20:59:52 +0530 Subject: [PATCH 2/2] fixing checkstyle warning HDFS-17847 --- .../hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java index 89edc1144a760..646ec314dfda1 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java @@ -266,7 +266,8 @@ public static int run(String[] args) throws Exception { return -1; } if ((out != null) && out.checkError()) { - System.err.println("CRITICAL FAILURE: PrintStream reported a write error (e.g., Disk Full)."); + System.err.println("CRITICAL FAILURE: PrintStream reported a write error " + + "(e.g., Disk Full)."); return -1; } return 0;