From 8f03c4429f9274a6b3d73271a2a752a29dbe9c95 Mon Sep 17 00:00:00 2001 From: Andrew Purtell Date: Tue, 23 Feb 2021 14:38:45 -0800 Subject: [PATCH] HBASE-25556 Frequent replication "Encountered a malformed edit" warnings (#2965) ProtobufLogReader#readNext may be called by code that attempts to advance the reader but does not necessarily expect to succeed, for example WALEntryStream#tryAdvanceEntry. Much of the logging in this method is at TRACE level. Other logging at WARN level will be frequently emitted, as often as several per minute, and this will cause false positive assessment from operators that they are experiencing a bug. Fix the mixed intent with respect to log levels in readNext. Log at only DEBUG level or below. Signed-off-by: Sean Busbey --- .../hadoop/hbase/regionserver/wal/ProtobufLogReader.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java index 0967c101ce58..9cd48c056b7a 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java @@ -408,14 +408,14 @@ protected boolean readNext(Entry entry) throws IOException { } catch (EOFException eof) { // If originalPosition is < 0, it is rubbish and we cannot use it (probably local fs) if (originalPosition < 0) { - LOG.warn("Encountered a malformed edit, but can't seek back to last good position " + LOG.debug("Encountered a malformed edit, but can't seek back to last good position " + "because originalPosition is negative. last offset={}", this.inputStream.getPos(), eof); throw eof; } // If stuck at the same place and we got an exception, lets go back at the beginning. if (inputStream.getPos() == originalPosition) { if (resetPosition) { - LOG.warn("Encountered a malformed edit, seeking to the beginning of the WAL since " + LOG.debug("Encountered a malformed edit, seeking to the beginning of the WAL since " + "current position and original position match at {}", originalPosition); seekOnFs(0); } else { @@ -424,7 +424,7 @@ protected boolean readNext(Entry entry) throws IOException { } else { // Else restore our position to original location in hope that next time through we will // read successfully. - LOG.warn("Encountered a malformed edit, seeking back to last good position in file, " + LOG.debug("Encountered a malformed edit, seeking back to last good position in file, " + "from {} to {}", inputStream.getPos(), originalPosition, eof); seekOnFs(originalPosition); }