From cb78b103a7a24ea49e6bc7716d31a9e8bf15ea3a Mon Sep 17 00:00:00 2001 From: Wellington Ramos Chevreuil Date: Wed, 15 Jan 2020 11:48:29 +0000 Subject: [PATCH] HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible (#1027) Signed-off-by: Bharath Vissapragada Signed-off-by: Josh Elser Signed-off-by: binlijin --- .../HBaseInterClusterReplicationEndpoint.java | 24 ++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java index ccdcee13f3b3..6f1f8b379aef 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java @@ -113,6 +113,25 @@ public class HBaseInterClusterReplicationEndpoint extends HBaseReplicationEndpoi private boolean dropOnDeletedTables; private boolean isSerial = false; + /* + * Some implementations of HBaseInterClusterReplicationEndpoint may require instantiate different + * Connection implementations, or initialize it in a different way, so defining createConnection + * as protected for possible overridings. + */ + protected AsyncClusterConnection createConnection(Configuration conf) throws IOException { + return ClusterConnectionFactory.createAsyncClusterConnection(conf, + null, User.getCurrent()); + } + + /* + * Some implementations of HBaseInterClusterReplicationEndpoint may require instantiate different + * ReplicationSinkManager implementations, or initialize it in a different way, + * so defining createReplicationSinkManager as protected for possible overridings. + */ + protected ReplicationSinkManager createReplicationSinkManager(AsyncClusterConnection conn) { + return new ReplicationSinkManager(conn, this, this.conf); + } + @Override public void init(Context context) throws IOException { super.init(context); @@ -131,13 +150,12 @@ public void init(Context context) throws IOException { // TODO: This connection is replication specific or we should make it particular to // replication and make replication specific settings such as compression or codec to use // passing Cells. - this.conn = - ClusterConnectionFactory.createAsyncClusterConnection(conf, null, User.getCurrent()); + this.conn = createConnection(this.conf); this.sleepForRetries = this.conf.getLong("replication.source.sleepforretries", 1000); this.metrics = context.getMetrics(); // ReplicationQueueInfo parses the peerId out of the znode for us - this.replicationSinkMgr = new ReplicationSinkManager(conn, this, this.conf); + this.replicationSinkMgr = createReplicationSinkManager(conn); // per sink thread pool this.maxThreads = this.conf.getInt(HConstants.REPLICATION_SOURCE_MAXTHREADS_KEY, HConstants.REPLICATION_SOURCE_MAXTHREADS_DEFAULT);