-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-20494 Updated the version of metrics-core to 3.2.6 #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 pending qabot
💔 -1 overall
This message was automatically generated. |
Test failures (timeouts) seem to be unrelated to the actual changes. |
@busbey The test failures seem to be unrelated. Does your approval remain? |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch LGTM. Would be good to trigger a build rerun if possible. Otherwise merge and we'll keep an eye on it.
@saintstack Have the same problem on another PR, where I would like to retrigger the build. Didn't see that option in Jenkins. Do you know how to do it without doing a fake push? |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to redo test runs in the PR testing qabot set up. Let's get this in and then keep an eye on nightly.
Raised the version of metrics-core from 3.2.1 to 3.2.6.