HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private void updatePermissionStorage(MasterProcedureEnv env) throws IOException { | ||
| try (Table table = | ||
| env.getMasterServices().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME)) { | ||
| // update permission to acl table |
| switch (state) { | ||
| case UPDATE_PERMISSION_STORAGE: | ||
| try { | ||
| // update permission in acl table and acl znode |
| } catch (KeeperException e) { | ||
| LOG.error("Failed deleting acl node '{}'", zkNode, e); | ||
| watcher.abort("Failed deleting node " + zkNode, e); | ||
| } |
|
💔 -1 overall
This message was automatically generated. |
| private void updatePermissionStorage(MasterProcedureEnv env) throws IOException { | ||
| try (Table table = | ||
| env.getMasterServices().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME)) { | ||
| // update permission to acl table |
| switch (state) { | ||
| case UPDATE_PERMISSION_STORAGE: | ||
| try { | ||
| // update permission in acl table and acl znode |
| } catch (KeeperException e) { | ||
| LOG.error("Failed deleting acl node '{}'", zkNode, e); | ||
| watcher.abort("Failed deleting node " + zkNode, e); | ||
| } |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 14, 2019
| PermissionStorage.addUserPermission(getConfiguration(), perm, table, | ||
| mergeExistingPermissions); | ||
| } | ||
| ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch(); |
There was a problem hiding this comment.
Maybe a better way is to add a proc id field in GrantResponse, and query the result at client side?
| ProcedureExecutor<MasterProcedureEnv> masterProcedureExecutor = | ||
| ((HasMasterServices) c.getEnvironment()).getMasterServices() | ||
| .getMasterProcedureExecutor(); | ||
| ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch(); |
There was a problem hiding this comment.
Do we really need to wait here?
| ProcedureExecutor<MasterProcedureEnv> masterProcedureExecutor = | ||
| ((HasMasterServices) ctx.getEnvironment()).getMasterServices() | ||
| .getMasterProcedureExecutor(); | ||
| ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch(); |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@mymeiyi any update? Thanks. |
|
💔 -1 overall
This message was automatically generated. |
… acls in Procedure
|
💔 -1 overall
This message was automatically generated. |
|
Will close this PR in next week or so unless it comes back to life. Thanks. |
|
Close this PR and will split this task into several minor tasks. Thanks for all comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UpdatePermissionProcedure to implement grant/revoke and RemovePermissionProcedure to implement delete namespace or table acls when delete namespace or table.