HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat #2209

utf7 · 2020-08-07T04:59:17Z

Avoid invoke Counter using reflection in SnapshotInputFormat

Apache-HBase · 2020-08-07T05:42:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 6s	master passed
+1 💚	checkstyle	0m 19s	master passed
+1 💚	spotbugs	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 12s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		31m 26s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 8c3e3ef1a060 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b49bd6`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-07T05:43:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	5m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	5m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	10m 39s	hbase-mapreduce in the patch failed.
		32m 12s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4ee066159630 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b49bd6`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/testReport/
Max. process+thread count	3821 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-07T05:45:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 41s	master passed
+1 💚	compile	0m 28s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-mapreduce in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	0m 32s	the patch passed
+1 💚	javac	0m 32s	the patch passed
+1 💚	shadedjars	6m 15s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	hbase-mapreduce in the patch failed.
		_ Other Tests _
-1 ❌	unit	10m 26s	hbase-mapreduce in the patch failed.
		34m 48s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 092640b82ec7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9b49bd6`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/testReport/
Max. process+thread count	3591 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

utf7 · 2020-08-07T07:05:55Z

with the pr we get about 7.6%/9.1% performance improve

in my test case with ScanPerformanceEvaluation tools

like that

hbase org.apache.hadoop.hbase.ScanPerformanceEvaluation -t snapshotscanmapreduce -rs /tmp/hbase/rs1 -sn sp_test

with pr

1#

total time to scan: 143943 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 109.1 MB/s
total rows : 10485760
throughput : 71.6 K rows/s
total cells : 104857600
throughput : 716.1 K cells/s

2#

total time to scan: 145948 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 107.6 MB/s
total rows : 10485760
throughput : 70.6 K rows/s
total cells : 104857600
throughput : 706.2 K cells/s

total time to scan: 149962 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 104.7 MB/s
total rows : 10485760
throughput : 68.7 K rows/s
total cells : 104857600
throughput : 687.2 K cells/s

without pr

1th:
total time to scan: 156929 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 100 MB/s
total rows : 10485760
throughput : 65.6 K rows/s
total cells : 104857600
throughput : 656.4 K cells/s

2th
total time to scan: 156078 ms
total bytes: 16357785600 bytes (15.2 G)
throughput : 100 MB/s
total rows : 10485760
throughput : 65.6 K rows/s
total cells : 104857600
throughput : 656.4 K cells/s

utf7 · 2020-08-07T07:06:26Z

The test error seems not related

utf7 · 2020-08-07T07:11:18Z

@anoopsjohn @pankaj72981 @tedyu @Apache9 @infraio mind have a looks,thanks

Apache9 · 2020-08-07T09:44:05Z

Mind explaing a bit why we do not need the reflection any more? Because we have dropped the support for some hadoop versions?

utf7 · 2020-08-07T15:54:12Z

Mind explaing a bit why we do not need the reflection any more? Because we have dropped the support for some hadoop versions?

Thanks for reply

I checkout the hadoop code with branch-2.7/branch-2.8/branch-2.9/branch-3/branch-3.0/branch-3.1/branch-3.2/branch-3.3

getCounter method just has two:

getCounter(Enum<?> counterName) or getCounter(String groupName, String counterName)

the code always pass two String params to invoke getCounter(String,String) ,

so I think we can just use getCounter(String,String)

besides that:

hadoop 2 version has been removed from hbase 3.0

in jdk11 case: We need a minimum HDFS version of 3.2.0 for HADOOP-12760

So, I think we can use getCounter(String,String) safely.

If i was wrong ,please correct me ,thanks

utf7 · 2020-08-11T01:25:44Z

format the log to trigger cicd

Apache-HBase · 2020-08-11T02:04:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	checkstyle	0m 20s	master passed
+1 💚	spotbugs	0m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		28m 11s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux fe4185d4563d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6fd7dce`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-11T02:08:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 17s	master passed
+1 💚	compile	0m 28s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 24s	hbase-mapreduce in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-mapreduce in the patch failed.
		_ Other Tests _
-1 ❌	unit	10m 22s	hbase-mapreduce in the patch failed.
		32m 47s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad8683cc7117 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6fd7dce`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/testReport/
Max. process+thread count	3845 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-11T02:13:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 28s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	shadedjars	6m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 23s	the patch passed
+1 💚	compile	0m 28s	the patch passed
+1 💚	javac	0m 28s	the patch passed
+1 💚	shadedjars	6m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
-1 ❌	unit	11m 52s	hbase-mapreduce in the patch failed.
		37m 44s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad527cf36100 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6fd7dce`
Default Java	1.8.0_232
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/testReport/
Max. process+thread count	4060 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

utf7 · 2020-08-25T12:59:05Z

fix NullPointerException when using TestTableSnapshotInputFormat,something the counter is null

before that, origin code using try-catch and debug log , here we using if (counter != null) { counter.increment(numScannerRestarts); } instead

utf7 · 2020-08-25T15:11:00Z

mind have a look @anoopsjohn thanks

Apache-HBase · 2020-08-25T17:20:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	checkstyle	0m 20s	master passed
+1 💚	spotbugs	0m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
-0 ⚠️	checkstyle	0m 18s	hbase-mapreduce: The patch generated 18 new + 9 unchanged - 0 fixed = 27 total (was 9)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 15s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	0m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		28m 28s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux af249efc8399 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebe321a`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-25T17:33:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 17s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	7m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	0m 28s	the patch passed
+1 💚	javac	0m 28s	the patch passed
+1 💚	shadedjars	7m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	11m 10s	hbase-mapreduce in the patch passed.
		38m 33s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 24a2f2787542 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebe321a`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/testReport/
Max. process+thread count	4869 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-25T17:40:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 49s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	shadedjars	7m 23s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 23s	hbase-mapreduce in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	7m 16s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 19s	hbase-mapreduce in the patch failed.
		_ Other Tests _
+1 💚	unit	13m 26s	hbase-mapreduce in the patch passed.
		41m 14s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2209
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e29418836b34 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebe321a`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/testReport/
Max. process+thread count	2907 (vs. ulimit of 12500)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2209/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

utf7 · 2020-08-28T07:52:18Z

done

…mat (#2209) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…mat (apache#2209) Signed-off-by: Duo Zhang <zhangduo@apache.org>

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat

d7e79a8

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat

2246fac

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat

f7338ba

Apache9 approved these changes Aug 25, 2020

View reviewed changes

infraio merged commit 04de594 into apache:master Sep 2, 2020

infraio pushed a commit that referenced this pull request Sep 2, 2020

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFor…

e042cab

…mat (#2209) Signed-off-by: Duo Zhang <zhangduo@apache.org>

infraio pushed a commit that referenced this pull request Sep 2, 2020

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFor…

b7c99fb

…mat (#2209) Signed-off-by: Duo Zhang <zhangduo@apache.org>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFor…

1d7cf81

…mat (apache#2209) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat #2209

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat #2209

utf7 commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

utf7 commented Aug 7, 2020

utf7 commented Aug 7, 2020

utf7 commented Aug 7, 2020

Apache9 commented Aug 7, 2020

utf7 commented Aug 7, 2020 •

edited

Loading

utf7 commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

utf7 commented Aug 25, 2020

utf7 commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

utf7 commented Aug 28, 2020

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat #2209

HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat #2209

Conversation

utf7 commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

Apache-HBase commented Aug 7, 2020

utf7 commented Aug 7, 2020

utf7 commented Aug 7, 2020

utf7 commented Aug 7, 2020

Apache9 commented Aug 7, 2020

utf7 commented Aug 7, 2020 • edited Loading

utf7 commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

Apache-HBase commented Aug 11, 2020

utf7 commented Aug 25, 2020

utf7 commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

Apache-HBase commented Aug 25, 2020

utf7 commented Aug 28, 2020

utf7 commented Aug 7, 2020 •

edited

Loading