-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25461 when the cluster has many tables, UI can be opened quickly #2843
base: master
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
9e67def
to
387249c
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
387249c
to
88ae68b
Compare
💔 -1 overall
This message was automatically generated. |
88ae68b
to
5e085f1
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@Apache9 @saintstack @pankaj72981 pls review, thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Skipping some otherwise expensive looking calls with lots of regions.
Just one question about not rendering splitting/merging regions. This might hide some problems. We should not have so many regions splitting/merging that it slows down the UI in a normal case. I think we show these regions today -- if we render split/merged regions on the UI, is the performance of the UI still better? Thanks.
if (regionStateNode.toRegionState().isSplitOrMerge()) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously would see splitting/merged regions for a specific table, right? The RegionState should be listed in the table of Regions for this HBase table -- are not showing split/merge regions a big performance impact?
No description provided.