-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup #2846
Conversation
Pull from master
…ffline RS to rsgroup
🎊 +1 overall
This message was automatically generated. |
…ffline RS to rsgroup
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, looks good otherwise
throw new ConstraintException("Source RSGroup for server " + firstServer | ||
+ " does not exist."); | ||
// Be careful. This exception message is tested for in TestRSGroupAdmin2... | ||
throw new ConstraintException("Server " + firstServer + " does not exist or offline."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
"Server " + firstServer + " is either offline or it does not exist."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
…ffline RS to rsgroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending QA
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…ffline RS to rsgroup (apache#2847) (apache#2846) Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 821f422) Change-Id: Iaf5eafc91f2b12dc931f80a40954e4cefe026f7a
No description provided.