HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports #2854

Apache9 · 2021-01-07T04:04:40Z

No description provided.

Apache-HBase · 2021-01-07T04:37:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	20m 54s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		31m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux b98958fc5b59 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-07T08:50:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	3m 5s	master passed
+1 💚	shadedjars	7m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 35s	the patch passed
+1 💚	compile	3m 10s	the patch passed
+1 💚	javac	3m 10s	the patch passed
+1 💚	shadedjars	7m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	245m 18s	root in the patch passed.
		285m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9fcab4c4083d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/testReport/
Max. process+thread count	4488 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-01-08T01:20:18Z

Ping @apurtell.

And @petersomogyi FYI.

petersomogyi · 2021-01-08T09:46:18Z

pom.xml

+                <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+                  <includeTestCode>true</includeTestCode>
+                  <commentLineBufferSize>512</commentLineBufferSize>
+                  <reason>Use RestrictedApi annotation in error prone instead</reason>


HBASE-24640 replaced VisibleForTesting with IA.Private annotation. The reason in this restrictImports should recommend the same.

I do not think this is the case. Even in IA.Public classes, not all the IA.Private annotations are for testing, and here we are telling a more general rule, not only for IA.Public classes. Saying that use IA.Private instead of VisibleForTesting will make developers confusing.
Let me see if I could make things more clear.

I changed the wording. PTAL. Thanks.

Apache-HBase · 2021-01-08T10:15:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		25m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux be5615f08817 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `45ef88d`
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T14:45:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 41s	master passed
+1 💚	compile	3m 8s	master passed
+1 💚	shadedjars	7m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	3m 6s	the patch passed
+1 💚	javac	3m 6s	the patch passed
+1 💚	shadedjars	7m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	256m 2s	root in the patch passed.
		295m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 47b5f77eedf0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `45ef88d`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/testReport/
Max. process+thread count	4545 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T16:48:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	2m 38s	master passed
+1 💚	shadedjars	7m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	2m 36s	the patch passed
+1 💚	javac	2m 36s	the patch passed
+1 💚	shadedjars	7m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	383m 27s	root in the patch passed.
		418m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d08b4343c78b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `45ef88d`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/testReport/
Max. process+thread count	4470 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T17:18:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	19m 9s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		27m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux 9f0ce4e2377a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c233e9`
Max. process+thread count	63 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T22:20:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 46s	master passed
+1 💚	compile	3m 8s	master passed
+1 💚	shadedjars	7m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
+1 💚	shadedjars	7m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	289m 15s	root in the patch passed.
		330m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2d726b89cdde 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c233e9`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/testReport/
Max. process+thread count	4261 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T23:50:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	2m 41s	master passed
+1 💚	shadedjars	7m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	2m 37s	the patch passed
+1 💚	javac	2m 37s	the patch passed
+1 💚	shadedjars	7m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	384m 29s	root in the patch passed.
		419m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2854
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 21643e088cd1 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5c233e9`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/testReport/
Max. process+thread count	4626 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2854/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…2854) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

Apache9 self-assigned this Jan 7, 2021

Apache9 requested a review from apurtell January 7, 2021 04:04

petersomogyi reviewed Jan 8, 2021

View reviewed changes

Apache9 force-pushed the HBASE-25333 branch from 538d529 to 08a2a58 Compare January 8, 2021 11:02

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

d0e1802

Apache9 force-pushed the HBASE-25333 branch from 08a2a58 to d0e1802 Compare January 8, 2021 11:02

petersomogyi approved these changes Jan 8, 2021

View reviewed changes

Apache9 merged commit 4925a64 into apache:master Jan 9, 2021

Apache9 added a commit that referenced this pull request Jan 9, 2021

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports (#…

75f5cb2

…2854) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

Apache9 added a commit that referenced this pull request Jan 9, 2021

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports (#…

751431d

…2854) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports #2854

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports #2854

Apache9 commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache9 commented Jan 8, 2021

petersomogyi Jan 8, 2021

Apache9 Jan 8, 2021

Apache9 Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports #2854

HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports #2854

Conversation

Apache9 commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache9 commented Jan 8, 2021

petersomogyi Jan 8, 2021

Choose a reason for hiding this comment

Apache9 Jan 8, 2021

Choose a reason for hiding this comment

Apache9 Jan 8, 2021

Choose a reason for hiding this comment

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021

Apache-HBase commented Jan 8, 2021