HBASE-25548 Optionally allow snapshots to preserve cluster's max file… #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size config by setting it into table descriptor
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
petersomogyi
reviewed
Feb 5, 2021
| @@ -150,6 +150,9 @@ | |||
| /** number of current operations running on the master */ | |||
| public static final int SNAPSHOT_POOL_THREADS_DEFAULT = 1; | |||
|
|
|||
| /** Conf key for preserving original max file size configs */ | |||
| public static final String SNAPSHOT_MAX_FILE_SIZE_PRESERVE = "hbase.snpashot.max.filesize.preserve"; | |||
|
💔 -1 overall
This message was automatically generated. |
|
I had a thought that with this change the HBase level configuration for the region size will become table level configuration for a restored snapshot. This is a highly hidden consequence of setting It might be better from an operational viewpoint to add an extra flag for creating a snapshot to preserve the system's region size for a configuration and do not use this feature for every snapshot in the cluster. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anoopsjohn
reviewed
Feb 15, 2021
| TableDescriptor htd = | ||
| this.master.getTableDescriptors().get(snapshotTable); | ||
| if (htd == null) { | ||
| throw new IOException("TableDescriptor missing for " + snapshotTable); | ||
| } | ||
| if(htd.getMaxFileSize()==-1 && |
There was a problem hiding this comment.
When we have max file size already set on a table (at src cluster) we will be preserving it in snapshot's HTD anyways right. Just confirming.
Also while taking snapshot, we can pass in this new config hbase.snapshot.max.filesize.preserve = true right?
Very useful feature.
There was a problem hiding this comment.
When we have max file size already set on a table (at src cluster) we will be preserving it in snapshot's HTD anyways right. Just confirming.
Yes, it won't be overridden by the system's region size configuration.
Also while taking snapshot, we can pass in this new config hbase.snapshot.max.filesize.preserve = true right?
Very useful feature.
The current proposal sets this at the system level so all snapshots taken will use this. I'd also like this configuration to be passed at snapshot creation.
There was a problem hiding this comment.
Thanks for the reviews and suggestions @anoopsjohn @petersomogyi . I'm falling behind a bit, but will be putting it in an upcoming commit on the following days.
There was a problem hiding this comment.
The current proposal sets this at the system level so all snapshots taken will use this. I'd also like this configuration to be passed at snapshot creation.
Sure. +1 for handling it as follow up issue
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
wchevreuil
force-pushed
the
HBASE-25548
branch
from
3863e99 to
2779089
Compare
… max_filesize as command property
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
reviewed
Mar 2, 2021
Had addressed the whitespace and checkstyle issues. I'm not sure about the reported spotbugs issue, it's complaining about |
petersomogyi
approved these changes
Mar 8, 2021
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…size config by setting it into table descriptor