Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949 #2958

Closed
wants to merge 6 commits into from

Conversation

pankaj72981
Copy link
Contributor

Upgrade the libthrift version to 0.14.0

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 54s master passed
+1 💚 compile 8m 7s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 3m 10s root in the patch failed.
-1 ❌ compile 6m 22s root in the patch failed.
-0 ⚠️ javac 6m 22s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
-1 ❌ hadoopcheck 2m 25s The patch causes 10 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 4m 55s The patch causes 10 errors with Hadoop v3.2.1.
-1 ❌ hadoopcheck 7m 25s The patch causes 10 errors with Hadoop v3.3.0.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
31m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux f98d6617798d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2f85e5
Default Java AdoptOpenJDK-1.8.0_232-b09
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-compile-root.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 52s master passed
+1 💚 compile 3m 6s master passed
+1 💚 shadedjars 7m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 4s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 4m 9s root in the patch failed.
-1 ❌ compile 2m 23s root in the patch failed.
-0 ⚠️ javac 2m 23s root in the patch failed.
+1 💚 shadedjars 8m 10s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 2m 19s root in the patch failed.
_ Other Tests _
-1 ❌ unit 17m 35s root in the patch failed.
55m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 79d4374474b6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2f85e5
Default Java AdoptOpenJDK-11.0.6+10
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/testReport/
Max. process+thread count 654 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
Copy link
Contributor Author

pankaj72981 commented Feb 15, 2021

Couldn't find the libthrift 0.14.0 jar in Apache maven repo...

[ERROR] Failed to execute goal on project hbase-thrift: Could not resolve dependencies for project org.apache.hbase:hbase-thrift:jar:3.0.0-SNAPSHOT: Failure to find org.apache.thrift:libthrift:jar:0.14.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

@saintstack Sir, how new jars are uploaded in Apache maven repo?

@apurtell
Copy link
Contributor

apurtell commented Feb 15, 2021

search.maven.org shows latest version as 0.13.0.

Apache repos also are in the same state: https://repository.apache.org/content/groups/public/org/apache/thrift/libthrift/ and https://repository.apache.org/content/repositories/releases/org/apache/thrift/libthrift/

The Thrift project hasn't completed the release of 0.14.0, we can't take a dependency on it until that happens.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 12s master passed
+1 💚 compile 8m 31s master passed
_ Patch Compile Tests _
-1 ❌ mvninstall 3m 40s root in the patch failed.
-1 ❌ compile 6m 45s root in the patch failed.
-0 ⚠️ javac 6m 45s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
-1 ❌ hadoopcheck 2m 42s The patch causes 26 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 5m 25s The patch causes 26 errors with Hadoop v3.2.1.
-1 ❌ hadoopcheck 8m 13s The patch causes 26 errors with Hadoop v3.3.0.
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
34m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux 8778fe3e6e82 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34bd1bd
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-compile-root.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 4m 4s master passed
+1 💚 compile 8m 34s master passed
+1 💚 checkstyle 2m 16s master passed
-1 ❌ spotbugs 10m 10s root in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 8m 30s the patch passed
+1 💚 javac 8m 30s the patch passed
-0 ⚠️ checkstyle 2m 13s root: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 18s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 36s hbase-thrift in the patch passed.
+1 💚 spotbugs 0m 52s hbase-examples in the patch passed.
+1 💚 spotbugs 10m 4s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
84m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 1ca4cac5ffb1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34bd1bd
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 4m 7s master passed
+1 💚 compile 8m 59s master passed
+1 💚 checkstyle 2m 15s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 56s the patch passed
+1 💚 compile 9m 21s the patch passed
+1 💚 javac 9m 21s the patch passed
+1 💚 checkstyle 2m 20s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 24s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
62m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 21fe1f84310b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b24bd40
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 48s master passed
+1 💚 compile 8m 57s master passed
+1 💚 checkstyle 2m 17s master passed
-1 ❌ spotbugs 10m 55s root in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 compile 9m 36s the patch passed
+1 💚 javac 9m 36s the patch passed
+1 💚 checkstyle 2m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 22m 36s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 38s hbase-thrift in the patch passed.
+1 💚 spotbugs 0m 54s hbase-examples in the patch passed.
+1 💚 spotbugs 10m 18s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
90m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 422119df01bc 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b522d2a
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 2m 35s master passed
+1 💚 shadedjars 7m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 2m 38s the patch passed
+1 💚 javac 2m 38s the patch passed
+1 💚 shadedjars 7m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 4s the patch passed
_ Other Tests _
+1 💚 unit 404m 23s root in the patch passed.
442m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 171f55ef1ddc 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b522d2a
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/testReport/
Max. process+thread count 3962 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 54s Docker failed to build run-specific yetus/hbase:tp-7068}.
Subsystem Report/Notes
GITHUB PR #2958
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/6/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 9m 38s master passed
+1 💚 checkstyle 2m 38s master passed
-1 ❌ spotbugs 10m 55s root in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 compile 8m 28s the patch passed
+1 💚 javac 8m 28s the patch passed
+1 💚 checkstyle 2m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 18m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 34s hbase-thrift in the patch passed.
+1 💚 spotbugs 0m 50s hbase-examples in the patch passed.
+1 💚 spotbugs 10m 17s root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
87m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux b257cd894111 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a97a40c
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/console
versions git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
+1 💚 mvninstall 4m 42s master passed
+1 💚 compile 3m 6s master passed
+1 💚 shadedjars 7m 51s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 17s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 5m 0s the patch passed
+1 💚 compile 3m 13s the patch passed
+1 💚 javac 3m 13s the patch passed
+1 💚 shadedjars 7m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 18s the patch passed
_ Other Tests _
+1 💚 unit 255m 34s root in the patch passed.
302m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 286ab3f50668 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a97a40c
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/testReport/
Max. process+thread count 4995 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 2m 37s master passed
+1 💚 shadedjars 7m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 2m 37s the patch passed
+1 💚 javac 2m 37s the patch passed
+1 💚 shadedjars 7m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 5s the patch passed
_ Other Tests _
-1 ❌ unit 398m 23s root in the patch failed.
437m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3e74d48d25fd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a97a40c
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/testReport/
Max. process+thread count 4015 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
Copy link
Contributor Author

Recently thrift 0.14.1 released due to some bug fixed, will update the PR with thrift 0.14.1 version.

Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's a CVE in 0.13.x, this is a much needed adition!

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 41s Maven dependency ordering for branch
+1 💚 mvninstall 3m 37s master passed
+1 💚 compile 8m 8s master passed
+1 💚 checkstyle 1m 55s master passed
-1 ❌ spotbugs 8m 57s root in master has 2 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 28s the patch passed
+1 💚 compile 8m 12s the patch passed
+1 💚 javac 8m 12s the patch passed
+1 💚 checkstyle 1m 53s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 17m 26s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 33s hbase-thrift in the patch passed.
+1 💚 spotbugs 0m 53s hbase-examples in the patch passed.
+1 💚 spotbugs 9m 36s root generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
78m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 7e80903bd15a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 373dc77
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 37s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s master passed
+1 💚 compile 2m 20s master passed
+1 💚 shadedjars 6m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 2m 24s the patch passed
+1 💚 javac 2m 24s the patch passed
+1 💚 shadedjars 6m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 53s the patch passed
_ Other Tests _
-1 ❌ unit 264m 23s root in the patch failed.
300m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux ff7097cceefd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 373dc77
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/testReport/
Max. process+thread count 5009 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 44s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 4m 38s master passed
+1 💚 compile 3m 10s master passed
+1 💚 shadedjars 7m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 20s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 34s the patch passed
+1 💚 compile 3m 9s the patch passed
+1 💚 javac 3m 9s the patch passed
+1 💚 shadedjars 7m 35s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 22s the patch passed
_ Other Tests _
-1 ❌ unit 261m 57s root in the patch failed.
309m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 39e9448ba292 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 373dc77
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/testReport/
Max. process+thread count 2530 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/8/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 10m 15s master passed
+1 💚 checkstyle 2m 35s master passed
-1 ❌ spotbugs 12m 7s root in master has 2 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 4m 17s the patch passed
+1 💚 compile 10m 29s the patch passed
+1 💚 javac 10m 29s the patch passed
+1 💚 checkstyle 2m 28s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 23m 6s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 57s hbase-thrift in the patch passed.
+1 💚 spotbugs 1m 3s hbase-examples in the patch passed.
+1 💚 spotbugs 12m 4s root generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
_ Other Tests _
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
102m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2958
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 7f66daa6933d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0e6c2c4
Default Java AdoptOpenJDK-1.8.0_282-b08
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981
Copy link
Contributor Author

@apurtell @Apache9 @nkalmar

Have raised another PR#3043, kindly review that.

Closing this PR now.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 41s Maven dependency ordering for branch
+1 💚 mvninstall 5m 47s master passed
+1 💚 compile 3m 35s master passed
+1 💚 shadedjars 8m 41s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 6m 0s the patch passed
+1 💚 compile 4m 4s the patch passed
+1 💚 javac 4m 4s the patch passed
+1 💚 shadedjars 8m 56s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 44s the patch passed
_ Other Tests _
+1 💚 unit 278m 7s root in the patch passed.
331m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8ac30f18d467 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0e6c2c4
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/testReport/
Max. process+thread count 4332 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 3m 27s master passed
+1 💚 compile 2m 22s master passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 52s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 29s the patch passed
+1 💚 compile 2m 25s the patch passed
+1 💚 javac 2m 25s the patch passed
+1 💚 shadedjars 6m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 55s the patch passed
_ Other Tests _
-1 ❌ unit 339m 39s root in the patch failed.
375m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2958
Optional Tests javac javadoc unit shadedjars compile
uname Linux a5ca6d20288e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0e6c2c4
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/testReport/
Max. process+thread count 6380 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2958/9/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants