-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start #3250
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. After fixing the spot bugs!
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Spotbugs warn looks like a false positive case which will never happen technically, as multiple thread can't call NettyRpcServer#start concurrently (start() is synchronized) and we have a check whether NettyRpcServer started before creating a new AuthenticationTokenSecretManager instance.
|
Missed to handle in SimpleRpcServer, handled in second commit. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 again.
…eption in AuthenticationTokenSecretManager.start
…eption in AuthenticationTokenSecretManager.start
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Test case failures are not relevant, passing locally. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Test case failures are not relevant, passing locally. |
…tion due to race condition in AuthenticationTokenSecretManager (#3250) * HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager's start & retrievePassword method Signed-off-by: stack <stack@apache.com> (cherry picked from commit 2126ec9)
…tion due to race condition in AuthenticationTokenSecretManager (#3250) * HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager's start & retrievePassword method Signed-off-by: stack <stack@apache.com> (cherry picked from commit 2126ec9)
…tion due to race condition in AuthenticationTokenSecretManager (#3250) * HBASE-25875 RegionServer failed to start with IllegalThreadStateException due to race condition in AuthenticationTokenSecretManager's start & retrievePassword method Signed-off-by: stack <stack@apache.com> (cherry picked from commit 2126ec9)
No description provided.