HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… #3251

saintstack · 2021-05-10T20:19:10Z

…gic marker

Apache-HBase · 2021-05-10T21:17:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	branch-2 passed
+1 💚	compile	4m 17s	branch-2 passed
+1 💚	checkstyle	1m 54s	branch-2 passed
+1 💚	spotbugs	4m 19s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 24s	the patch passed
+1 💚	compile	5m 18s	the patch passed
+1 💚	javac	5m 18s	the patch passed
+1 💚	checkstyle	0m 39s	hbase-client: The patch generated 0 new + 57 unchanged - 1 fixed = 57 total (was 58)
+1 💚	checkstyle	1m 23s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 37s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	4m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		56m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3251
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux fe68fdf12963 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `4e507cc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-11T00:38:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 24s	branch-2 passed
+1 💚	compile	1m 48s	branch-2 passed
+1 💚	shadedjars	7m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 20s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	7m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 2s	hbase-client in the patch passed.
+1 💚	unit	217m 11s	hbase-server in the patch passed.
		258m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3251
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 86bde040dcae 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `4e507cc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/testReport/
Max. process+thread count	2966 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-11T01:02:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 50s	branch-2 passed
+1 💚	compile	1m 42s	branch-2 passed
+1 💚	shadedjars	7m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 35s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	7m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 40s	hbase-client in the patch passed.
-1 ❌	unit	244m 22s	hbase-server in the patch failed.
		282m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3251
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf35dfab3c53 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `4e507cc`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/testReport/
Max. process+thread count	2333 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-05-12T13:02:17Z

hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java

@@ -964,8 +965,7 @@ public static HRegionInfo parseFrom(final DataInputStream in) throws IOException
    }

    //assumption: if Writable serialization, it should be longer than pblen.
-    int read = in.read(pbuf);
-    if (read != pblen) throw new IOException("read=" + read + ", wanted=" + pblen);
+    IOUtils.readFully(in, pbuf, 0, pblen);


DataInputStream has a readFully method, so I think here we could just use that one?

Let me do your suggestion instead. Thanks.

…gic marker

Apache-HBase · 2021-05-12T14:02:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	branch-2 passed
+1 💚	compile	4m 6s	branch-2 passed
+1 💚	checkstyle	1m 39s	branch-2 passed
+1 💚	spotbugs	3m 7s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	4m 8s	the patch passed
+1 💚	javac	4m 8s	the patch passed
+1 💚	checkstyle	0m 33s	hbase-client: The patch generated 0 new + 57 unchanged - 1 fixed = 57 total (was 58)
+1 💚	checkstyle	1m 6s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 43s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		46m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3251
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux a154375e6593 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `61d9b46`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T17:20:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 30s	branch-2 passed
+1 💚	compile	1m 45s	branch-2 passed
+1 💚	shadedjars	7m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 11s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	1m 44s	the patch passed
+1 💚	javac	1m 44s	the patch passed
+1 💚	shadedjars	7m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 46s	hbase-client in the patch passed.
+1 💚	unit	206m 33s	hbase-server in the patch passed.
		243m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3251
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 960bb1b3db1b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `61d9b46`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/testReport/
Max. process+thread count	2793 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3251/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…gic marker (#3251) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>

…gic marker (#3251) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> (cherry picked from commit 0755457)

anoopsjohn approved these changes May 11, 2021

View reviewed changes

Apache9 reviewed May 12, 2021

View reviewed changes

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

907e114

…gic marker

saintstack force-pushed the HBASE-25876 branch from 9d18827 to 907e114 Compare May 12, 2021 13:16

Apache9 approved these changes May 12, 2021

View reviewed changes

saintstack merged commit 0755457 into apache:branch-2 May 12, 2021

saintstack added a commit that referenced this pull request May 12, 2021

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

1c829af

…gic marker (#3251) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… #3251

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… #3251

saintstack commented May 10, 2021

Apache-HBase commented May 10, 2021

Apache-HBase commented May 11, 2021

Apache-HBase commented May 11, 2021

Apache9 May 12, 2021

saintstack May 12, 2021

Apache-HBase commented May 12, 2021

Apache-HBase commented May 12, 2021

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… #3251

HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma… #3251

Conversation

saintstack commented May 10, 2021

Apache-HBase commented May 10, 2021

Apache-HBase commented May 11, 2021

Apache-HBase commented May 11, 2021

Apache9 May 12, 2021

Choose a reason for hiding this comment

saintstack May 12, 2021

Choose a reason for hiding this comment

Apache-HBase commented May 12, 2021

Apache-HBase commented May 12, 2021