HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings #3562
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
reviewed
Aug 6, 2021
| @@ -331,12 +331,12 @@ protected Path createInputFileListing(Job job) throws IOException { | |||
| private Text getKey(Path path) { | |||
| int level = conf.getInt(NUMBER_OF_LEVELS_TO_PRESERVE_KEY, 1); | |||
| int count = 0; | |||
| String relPath = ""; | |||
| StringBuilder relPath = new StringBuilder(); | |||
There was a problem hiding this comment.
It's not that obvious to me that using StringBuilder in this way is faster (looking at the jira, I assumed this is the purpose of the change) than simple string concatenation, because StringBuilder.insert() may involve multiple array copy.
How about instantiating StringBuilder with a capacity (=level) as parameter so that we don't need to re-allocate & copy arrays?
There was a problem hiding this comment.
But the length of path.getName() is not fixed, how to determine the initial capacity?
Unless the Path is traversed again and the length of the name is calculated, the performance will obviously not improve. Splicing strings in a loop will generate a new string each time. In my opinion, using StringBuilder will improve performance, thanks
There was a problem hiding this comment.
Maybe a possible way is to store the path name in a list and then concat the list of strings from tail to head?
There was a problem hiding this comment.
But is it acceptable to apply for the space of the collection and the time cost of traversing the collection again?
There was a problem hiding this comment.
@Apache9 I changed to use a collection to store strings, PTAL
There was a problem hiding this comment.
looks good to me. Thank you.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapReduceBackupCopyJob.BackupDistCp.getKey()concatenates strings in a loop, should consider usingStringBuilderto concatenate strings, thanks