HBASE-22709 Add a chore thread in master to do hbck checking #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Jul 25, 2019
There was a problem hiding this comment.
This is excellent.
Some comments. See what you think.
Lets get this in. I want to add the findings over in HBASE-22723 to your new hbck.jsp.
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChecker.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChecker.java
Show resolved
Hide resolved
| private final Map<String, ServerName> orphanRegionsOnRSSnapshot = new HashMap<>(); | ||
| private final List<String> orphanRegionsOnFSSnapshot = new LinkedList<>(); | ||
| private final Map<String, Pair<ServerName, List<ServerName>>> inconsistentRegionsSnapshot = | ||
| new HashMap<>(); |
| try { | ||
| loadRegionsFromFS(); | ||
| } catch (IOException e) { | ||
| LOG.warn("Faile to load the regions from filesystem", e); |
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChecker.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChecker.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChecker.java
Show resolved
Hide resolved
| if (hbckChecker != null) { | ||
| inconsistentRegions = hbckChecker.getInconsistentRegions(); | ||
| orphanRegionsOnRS = hbckChecker.getOrphanRegionsOnRS(); | ||
| orphanRegionsOnFS = hbckChecker.getOrphanRegionsOnFS(); |
There was a problem hiding this comment.
Yeah, so this stuff could be an hour old?
There was a problem hiding this comment.
Date it? See patch in HBASE-22741. It dates the CJ run Report.
There was a problem hiding this comment.
There are a date in the latest code.
saintstack
reviewed
Jul 25, 2019
saintstack
reviewed
Jul 25, 2019
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Let me check this. |
This can be done by a new issue. |
The ClusterStatusPublisher only publish version, master and deadservers. Didn't have overlap with this. |
|
💔 -1 overall
This message was automatically generated. |
|
Ok on all of the above. Can do aggregation as a follow-on if opportunity. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 26, 2019
| if (hbckChecker != null) { | ||
| inconsistentRegions = hbckChecker.getInconsistentRegions(); | ||
| orphanRegionsOnRS = hbckChecker.getOrphanRegionsOnRS(); | ||
| orphanRegionsOnFS = hbckChecker.getOrphanRegionsOnFS(); |
There was a problem hiding this comment.
Date it? See patch in HBASE-22741. It dates the CJ run Report.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2019
Signed-off-by: stack <stack@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 50e27e2) Change-Id: I1b5d8bfd183147f51f4503e4331d2de23d1656e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.