Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26709 Ban the usage of junit 3 TestCase #4065

Merged
merged 2 commits into from
Jan 27, 2022
Merged

HBASE-26709 Ban the usage of junit 3 TestCase #4065

merged 2 commits into from
Jan 27, 2022

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 26, 2022

No description provided.

@Apache9 Apache9 self-assigned this Jan 26, 2022
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 9m 32s master passed
+1 💚 checkstyle 2m 1s master passed
+1 💚 spotbugs 14m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 8m 59s the patch passed
-0 ⚠️ javac 8m 59s root generated 3 new + 1622 unchanged - 4 fixed = 1625 total (was 1626)
+1 💚 checkstyle 1m 58s root: The patch generated 0 new + 11 unchanged - 5 fixed = 11 total (was 16)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotbugs 14m 35s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
90m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4065
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 09d86f2b08d6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 53s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 5m 16s master passed
+1 💚 compile 3m 54s master passed
+1 💚 shadedjars 9m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 52s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 5m 13s the patch passed
+1 💚 compile 3m 51s the patch passed
+1 💚 javac 3m 51s the patch passed
+1 💚 shadedjars 8m 47s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 49s the patch passed
_ Other Tests _
-1 ❌ unit 172m 48s root in the patch failed.
224m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4065
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4c0907688c62 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/testReport/
Max. process+thread count 4010 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 52s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s master passed
+1 💚 compile 2m 54s master passed
+1 💚 shadedjars 9m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 39s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 3m 9s the patch passed
+1 💚 javac 3m 9s the patch passed
+1 💚 shadedjars 9m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 33s the patch passed
_ Other Tests _
-1 ❌ unit 365m 23s root in the patch failed.
413m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4065
Optional Tests javac javadoc unit shadedjars compile
uname Linux 56c5be32d960 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/testReport/
Max. process+thread count 4841 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 5m 19s master passed
+1 💚 compile 11m 26s master passed
+1 💚 checkstyle 2m 32s master passed
+1 💚 spotbugs 17m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 5m 9s the patch passed
+1 💚 compile 11m 5s the patch passed
+1 💚 javac 11m 5s root generated 0 new + 1625 unchanged - 1 fixed = 1625 total (was 1626)
+1 💚 checkstyle 2m 32s root: The patch generated 0 new + 11 unchanged - 5 fixed = 11 total (was 16)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 24m 55s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotbugs 14m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
107m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4065
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 608682791e0a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 5m 17s master passed
+1 💚 compile 3m 37s master passed
+1 💚 shadedjars 9m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 5m 6s the patch passed
+1 💚 compile 3m 36s the patch passed
+1 💚 javac 3m 36s the patch passed
+1 💚 shadedjars 9m 12s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 35s the patch passed
_ Other Tests _
+1 💚 unit 270m 21s root in the patch passed.
319m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4065
Optional Tests javac javadoc unit shadedjars compile
uname Linux 63a305e71dc8 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/testReport/
Max. process+thread count 4443 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 50s master passed
+1 💚 compile 2m 44s master passed
+1 💚 shadedjars 8m 16s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 28s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 55s the patch passed
+1 💚 compile 2m 46s the patch passed
+1 💚 javac 2m 46s the patch passed
+1 💚 shadedjars 8m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 27s the patch passed
_ Other Tests _
-1 ❌ unit 361m 21s root in the patch failed.
402m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4065
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9b384fe8ca44 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c33fa3a
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/testReport/
Max. process+thread count 4835 (vs. ulimit of 30000)
modules C: hbase-common hbase-http hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4065/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit f6348d4 into apache:master Jan 27, 2022
Apache9 added a commit that referenced this pull request Feb 9, 2022
@Apache9
HBASE-26709 Ban the usage of junit 3 TestCase (#4065)
b64a507 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Apache9 added a commit that referenced this pull request Feb 9, 2022
@Apache9
HBASE-26709 Ban the usage of junit 3 TestCase (#4065)
d747da6 
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @ndimiduk