-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26713 Default to LATEST_TIMESTAMP if no timestamp sent along on Increment/Append #4075
Conversation
The only real difference from #4074 here is that the exact same change was applied to non-shaded ProtobufUtil and non-shaded TestProtobufUtil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, approved, waiting for precommit results before committing.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Hmm looks like an unrelated StackOverflowError in TableOperationSpanBuilder. I think it originated in https://issues.apache.org/jira/browse/HBASE-26473, which I've pinged. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, unfortunately we have the StackoverflowError as already mentioned above by @bbeaudreault
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
… Increment/Append
f6d744b
to
1947ca9
Compare
Force push just to rebase on latest branch-2, which should fix the StackOverflowErrors and clear build here. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
… Increment/Append (#4075) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
… Increment/Append (#4075) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
… Increment/Append (#4075) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
… Increment/Append (apache#4075)
… Increment/Append (apache#4075) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 590e38e) Change-Id: I742c4be2eb4149813f13b0b072c6f8d591b3286e
Companion to #4074, for branch-2