-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks' #4095
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
ef77619
to
9d4099f
Compare
Address @gjacoby126 's feedback from #4094 and rebased. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
puts(format(' %s:%d %d', server.getHostname, server.getPort, server.getStartcode)) | ||
end | ||
|
||
master_coprocs = @admin.getMasterCoprocessorNames.toString | ||
master_coprocs = java.util.Arrays.toString(@admin.getMasterCoprocessors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems additional change, is it for better readability or it's just a mechanical change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a merge artifact. A mechanical change, I think you mean. I will undo it.
Few checkstyle warnings are present in the recent QA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks @apurtell
I see them @virajjasani , will fix before merge |
…'tasks' Expose monitored tasks state in ClusterStatus API via new option in ServerLoad. Add shell support for interrogating monitored tasks state in ServerLoad.
…sks in 'tasks' view
f599132
to
9d0b028
Compare
Expose monitored tasks state in ClusterStatus API via new option in ServerLoad.
Add shell support for interrogating monitored tasks state in ServerLoad.
Here's a prototype running on a branch-2 fork: