HBASE-26622 Update error-prone to 2.10 #4133

ndimiduk · 2022-02-24T13:56:45Z

Picks up on @madrob 's #3979 , applies the changes I outlined. Specifically:

Upgrades us to the last version of Error Prone that retains support for JDK8 compiler (happens to be the latest release, at this time)
Keeps the errorprone profile attached to JDK8 compiler profile
Minor changes regarding java docs and unit test warnings
Swap the KeyValue#clone method to use Arrays.copyOf as Mike suggested in the other PR.

Apache9 · 2022-02-25T01:00:20Z

hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java

- * @param P PB message that is used to transport initializer specific bytes
- * @param Q PB message that is used to transport Cell (&lt;T&gt;) instance
- * @param R PB message that is used to transport Promoted (&lt;S&gt;) instance
+ * @param <T> Cell value data type


Will this change introduce javadoc warning or checkstyle warning?

No, checking the precommit output, I see no new javadoc or checkstyle warnings originating from this file.

hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java

...-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMergesSplitsAddToTracker.java

Apache-HBase · 2022-03-01T14:58:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	5m 49s	master passed
+1 💚	checkstyle	1m 9s	master passed
+1 💚	spotbugs	10m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 20s	the patch passed
+1 💚	compile	6m 15s	the patch passed
-0 ⚠️	javac	6m 15s	root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)
+1 💚	checkstyle	1m 10s	root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 22s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	11m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 13s	The patch does not generate ASF License warnings.
		63m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 6d6b19e9ee6e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e85bf41`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-01T21:11:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s	master passed
+1 💚	compile	2m 10s	master passed
+1 💚	shadedjars	4m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	405m 28s	root in the patch passed.
		435m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ac920f911ce4 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e85bf41`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/
Max. process+thread count	2445 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-02T00:51:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	4m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 44s	the patch passed
+1 💚	compile	1m 57s	the patch passed
+1 💚	javac	1m 57s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	625m 43s	root in the patch passed.
		656m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b624280b7345 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e85bf41`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/
Max. process+thread count	2414 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Author: Mike Drob <mdrob@apache.org> Co-authored-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org>

Apache-HBase · 2022-03-02T15:59:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	5m 25s	master passed
+1 💚	checkstyle	1m 8s	master passed
+1 💚	spotbugs	10m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 20s	the patch passed
+1 💚	compile	6m 8s	the patch passed
-0 ⚠️	javac	6m 8s	root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)
+1 💚	checkstyle	1m 5s	root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	11m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		60m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 2a954ae14eee 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `87f8d9a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-02T21:15:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 12s	master passed
+1 💚	compile	1m 57s	master passed
+1 💚	shadedjars	4m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	4m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	347m 19s	root in the patch failed.
		376m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad9728fda56d 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `87f8d9a`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/
Max. process+thread count	1551 (vs. ulimit of 30000)
modules	C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-02T23:16:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	1m 39s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	471m 32s	root in the patch failed.
		496m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4133
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2240dd146828 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `87f8d9a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/
Max. process+thread count	1664 (vs. ulimit of 30000)
modules	C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk requested review from busbey, joshelser, madrob, jojochuang and Apache9 February 24, 2022 13:56

madrob approved these changes Feb 24, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

Apache9 reviewed Feb 25, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

ndimiduk force-pushed the 26622-upgrade-errorprone-2.10 branch from a4ca004 to a165f03 Compare February 28, 2022 10:25

This comment was marked as outdated.

Sign in to view

apurtell approved these changes Feb 28, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

ndimiduk force-pushed the 26622-upgrade-errorprone-2.10 branch from a165f03 to 81f38a7 Compare March 1, 2022 13:47

HBASE-26622 Update error-prone to 2.10

a552add

Author: Mike Drob <mdrob@apache.org> Co-authored-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org>

ndimiduk force-pushed the 26622-upgrade-errorprone-2.10 branch from 81f38a7 to a552add Compare March 2, 2022 14:58

ndimiduk merged commit 06f06cb into apache:master Mar 2, 2022

ndimiduk deleted the 26622-upgrade-errorprone-2.10 branch March 2, 2022 15:07

ndimiduk mentioned this pull request Mar 2, 2022

HBASE-26622 Update error-prone to 2.10 #3979

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26622 Update error-prone to 2.10 #4133

HBASE-26622 Update error-prone to 2.10 #4133

ndimiduk commented Feb 24, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache9 Feb 25, 2022

ndimiduk Feb 28, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 1, 2022

Apache-HBase commented Mar 1, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

HBASE-26622 Update error-prone to 2.10 #4133

HBASE-26622 Update error-prone to 2.10 #4133

Conversation

ndimiduk commented Feb 24, 2022 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache9 Feb 25, 2022

Choose a reason for hiding this comment

ndimiduk Feb 28, 2022

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 1, 2022

Apache-HBase commented Mar 1, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

Apache-HBase commented Mar 2, 2022

ndimiduk commented Feb 24, 2022 •

edited

Loading