HBASE-26720 ExportSnapshot should validate the source snapshot before copying files #4216

xicm · 2022-03-14T09:03:21Z

No description provided.

merge apache/hbase

Apache-HBase · 2022-03-14T09:05:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 1s	Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:20:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 7s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 54s	hbase-mapreduce in the patch passed.
		14m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 56af3ea0a87d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/testReport/
Max. process+thread count	872 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:21:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
-1 ❌	mvninstall	3m 25s	root in master failed.
+1 💚	compile	0m 22s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 47s	hbase-mapreduce in the patch passed.
		15m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 26b09f8fcc9a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-11.0.10+9
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/testReport/
Max. process+thread count	847 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:35:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 0s	Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:49:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 48s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 54s	hbase-mapreduce in the patch passed.
		13m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 7aeea560a5a1 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/testReport/
Max. process+thread count	822 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:49:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 43s	hbase-mapreduce in the patch passed.
		13m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 3f741a774142 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a49d147`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/testReport/
Max. process+thread count	868 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

xicm · 2022-03-14T09:52:24Z

how to deal with "Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0)."

apurtell · 2022-03-14T20:51:53Z

No concerns from me, @virajjasani did you want to review this? You interacted with the contributor on HBASE-26720

Apache-HBase · 2022-03-15T02:18:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 38s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	checkstyle	0m 15s	master passed
+1 💚	spotbugs	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 18s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotbugs	0m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		13m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux 78fa1ad272c6 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	57 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T02:23:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 59s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 29s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 2s	hbase-mapreduce in the patch passed.
		17m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 2573a74a8c04 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/testReport/
Max. process+thread count	871 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T02:25:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 14s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 50s	hbase-mapreduce in the patch passed.
		20m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux d26a5a72913d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f640b7f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/testReport/
Max. process+thread count	861 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

One minor nit, else looks good

virajjasani · 2022-03-15T07:31:33Z

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java

@@ -996,6 +1000,12 @@ public int doWork() throws IOException {
    LOG.debug("outputFs={}, outputRoot={}, skipTmp={}, initialOutputSnapshotDir={}",
      outputFs, outputRoot.toString(), skipTmp, initialOutputSnapshotDir);

+    // Verify snapshot source before copying files
+    if (verifySource) {
+      LOG.info("Verify snapshot source.");


How about adding srcConf, inputFs, inputRoot, snapshotDir values in the log as well?

I added inputFs, inputRoot, snapshotDir values in the log, srcConf contains too many things that I didn't add.

Apache-HBase · 2022-03-16T02:37:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 1s	Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T02:53:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 57s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 14s	hbase-mapreduce in the patch passed.
		17m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux c31bf5e42d83 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/testReport/
Max. process+thread count	866 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T02:55:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 4s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 51s	hbase-mapreduce in the patch passed.
		20m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux e0888d71c596 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/testReport/
Max. process+thread count	898 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T03:21:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 0s	Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem	Report/Notes
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T03:37:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 23s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 28s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 54s	hbase-mapreduce in the patch passed.
		17m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 79789a6ef02a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/testReport/
Max. process+thread count	856 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T03:40:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 25s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 58s	hbase-mapreduce in the patch passed.
		19m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4216
Optional Tests	javac javadoc unit compile
uname	Linux 525b1916d66c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4ec523`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/testReport/
Max. process+thread count	849 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4216/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… copying files (#4216) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

… copying files (apache#4216) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit 9043cb9) Change-Id: I470e8ac2963d3ff6271b7963e9acd849ff6d816e

xicm and others added 6 commits November 16, 2021 16:05

Merge pull request #1 from apache/master

f6c46cf

merge apache/hbase

Merge branch 'apache:master' into master

13e75fa

Merge branch 'apache:master' into master

b22f86f

Merge branch 'apache:master' into master

e497ed1

Merge branch 'apache:master' into master

f3485e5

HBASE-26720, validate the source snapshot before copying files

f4a9985

Merge branch 'apache:master' into master

2eb1ed2

Merge branch 'master' into HBASE-26720

7573c20

virajjasani changed the title ~~Hbase 26720, validate the source snapshot before copying files~~ HBASE-26720 validate the source snapshot before copying files Mar 14, 2022

virajjasani changed the title ~~HBASE-26720 validate the source snapshot before copying files~~ HBASE-26720 ExportSnapshot should validate the source snapshot before copying files Mar 14, 2022

apurtell approved these changes Mar 14, 2022

View reviewed changes

xicm and others added 2 commits March 15, 2022 10:01

Merge branch 'apache:master' into master

69d19a2

Merge branch 'master' into HBASE-26720

9cc15d2

virajjasani reviewed Mar 15, 2022

View reviewed changes

update log about check of snapshot source

ed39013

Merge branch 'apache:master' into master

4ab34d7

Merge branch 'master' into HBASE-26720

68ecb23

sunhelly approved these changes Mar 16, 2022

View reviewed changes

sunhelly merged commit ef280d4 into apache:master Mar 16, 2022

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26720 ExportSnapshot should validate the source snapshot before…

9043cb9

… copying files (#4216) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26720 ExportSnapshot should validate the source snapshot before…

4f3decd

… copying files (#4216) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26720 ExportSnapshot should validate the source snapshot before…

fdc7c49

… copying files (#4216) Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26720 ExportSnapshot should validate the source snapshot before copying files #4216

HBASE-26720 ExportSnapshot should validate the source snapshot before copying files #4216

xicm commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

xicm commented Mar 14, 2022

apurtell commented Mar 14, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

virajjasani left a comment

virajjasani Mar 15, 2022

xicm Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

HBASE-26720 ExportSnapshot should validate the source snapshot before copying files #4216

HBASE-26720 ExportSnapshot should validate the source snapshot before copying files #4216

Conversation

xicm commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

xicm commented Mar 14, 2022

apurtell commented Mar 14, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Mar 15, 2022

Choose a reason for hiding this comment

xicm Mar 16, 2022

Choose a reason for hiding this comment

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022