HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Reidddddd
commented
Aug 8, 2019
| @@ -7177,8 +7177,8 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException | |||
| fs.commitDaughterRegion(hri); | |||
|
|
|||
| // Create the daughter HRegion instance | |||
| HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), | |||
| this.getBaseConf(), hri, this.getTableDesc(), rsServices); | |||
| HRegion r = HRegion.newHRegion(this.fs.getTableDir(), rsServices.getWAL(hri), | |||
There was a problem hiding this comment.
rsServices.getWAL(hri)
Based on WALProvider impl, it will create a new wal according to strategy or inherit parent's wal by default mode.
|
2nd commit, improve some naming readability. |
|
💔 -1 overall
This message was automatically generated. |
|
Related failure, working.. |
3rd commit should fix the UT failure. |
Reidddddd
commented
Aug 8, 2019
| @@ -277,7 +323,7 @@ public void testWholesomeSplit() throws IOException { | |||
| assertTrue(count > 0 && count != rowcount); | |||
| daughtersRowCount += count; | |||
| } finally { | |||
| HRegion.closeHRegion((HRegion)openRegion); | |||
There was a problem hiding this comment.
HRegion.closeHRegion method will close WAL, then second daughter region will get exception. That's why i replace it with ((HRegion) openRegion).close()
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Unrelated failure. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
requested changes
Aug 12, 2019
| HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), | ||
| this.getBaseConf(), hri, this.getTableDesc(), rsServices); | ||
| HRegion r = HRegion.newHRegion(this.fs.getTableDir(), | ||
| rsServices == null ? getWAL() :rsServices.getWAL(hri), // rsServices can be null in UT |
There was a problem hiding this comment.
Please extract this expression to a variable.
| @@ -72,7 +72,7 @@ public void init(Configuration config, String providerId) { | |||
| int regionGroupNumber = config.getInt(NUM_REGION_GROUPS, DEFAULT_NUM_REGION_GROUPS); | |||
| groupNames = new String[regionGroupNumber]; | |||
| for (int i = 0; i < regionGroupNumber; i++) { | |||
| groupNames[i] = providerId + GROUP_NAME_DELIMITER + "regiongroup-" + i; | |||
There was a problem hiding this comment.
GROUP_NAME_DELIMITER is unused from now on. Can it be removed? It is in IA.Private class.
| @@ -277,7 +323,7 @@ public void testWholesomeSplit() throws IOException { | |||
| assertTrue(count > 0 && count != rowcount); | |||
| daughtersRowCount += count; | |||
| } finally { | |||
| HRegion.closeHRegion((HRegion)openRegion); | |||
|
💔 -1 overall
This message was automatically generated. |
|
2nd commit addressed comments only, failed tests are not related. |
|
Thanks Peter for the review! @petersomogyi |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link