-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27216 Revisit the ReplicationSyncUp tool #4966
HBASE-27216 Revisit the ReplicationSyncUp tool #4966
Conversation
@2005hithlj I've implemented the OfflineTableReplicationQueueStorage and I tried to re-enable TestReplicationSyncUpTool, it can start and run without any exceptions but it can not finish... Need to dig more. And I think you could start to find the way on how to truncate the hbase:replication table when master restarts? Thanks. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
OK, sir. |
e4e3363
to
ff31d25
Compare
ff31d25
to
bf1f008
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
bf1f008
to
069d1ca
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
(!) A patch to the testing environment has been detected. |
2 similar comments
(!) A patch to the testing environment has been detected. |
(!) A patch to the testing environment has been detected. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Apache9 sir, LGTM. But pr-merge failed, please check it.
for (ReplicationQueueId queueId : replicationQueues) { | ||
mgr.claimQueue(queueId, true); | ||
} | ||
} | ||
} | ||
|
||
@Override | ||
public int run(String[] args) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sir.
I have opened a new issue HBASE-27623.
I triggered a build again. Let's wait for the result. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
The jdk11 build passed so it should be some flaky tests. https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4966/17/testReport/ Here the only one failed UT is TestClusterScopeQuotaThrottle, should not be related. Let me merge. |
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
Signed-off-by: Liangjun He <heliangjun@apache.org>
No description provided.