[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 18, 2019
| @@ -504,6 +504,15 @@ private void initialize() { | |||
| } | |||
| } | |||
|
|
|||
| if (peerClusterId == null) { | |||
There was a problem hiding this comment.
I think here we just need to add the same check like above?
if (!this.isSourceActive()) {
return;
}
There was a problem hiding this comment.
Actually this makes more sense. Thanks for the idea.
| @@ -484,8 +484,10 @@ public void refreshSources(String peerId) throws IOException { | |||
| LOG.info("Terminate replication source for " + toRemove.getPeerId()); | |||
| toRemove.terminate(terminateMessage); | |||
| } | |||
| for (NavigableSet<String> walsByGroup : walsById.get(peerId).values()) { | |||
| walsByGroup.forEach(wal -> src.enqueueLog(new Path(this.logDir, wal))); | |||
| if (walsById.get(peerId) != null) { | |||
There was a problem hiding this comment.
And is this possible? In the addSource method, we will always put a Map into the walsByGroup for the corresponding peerId. Notice that the code for branch-2 have been changed a lot from branch-1 so...
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Aug 21, 2019
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apurtell This is the patch for master branch. please review.
Cherry-picking master commit applies cleanly to branch-2.