Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27969 TableReplicationQueueStorage.hasData does not work as exp… #5321

Merged
merged 1 commit into from
Jul 11, 2023
Merged

HBASE-27969 TableReplicationQueueStorage.hasData does not work as exp… #5321

merged 1 commit into from
Jul 11, 2023

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 10, 2023

…ected

@Apache9 Apache9 requested a review from 2005hithlj July 10, 2023 14:59
@Apache9 Apache9 self-assigned this Jul 10, 2023
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 31s master passed
+1 💚 compile 0m 12s master passed
+1 💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 0m 12s the patch passed
+1 💚 javac 0m 12s the patch passed
+1 💚 shadedjars 4m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 0m 31s hbase-replication in the patch passed.
16m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5321
Optional Tests javac javadoc unit shadedjars compile
uname Linux 73d01ccc8be5 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/testReport/
Max. process+thread count 219 (vs. ulimit of 30000)
modules C: hbase-replication U: hbase-replication
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 6s master passed
+1 💚 compile 0m 11s master passed
+1 💚 shadedjars 5m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 compile 0m 12s the patch passed
+1 💚 javac 0m 12s the patch passed
+1 💚 shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 0m 26s hbase-replication in the patch passed.
19m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5321
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1ef7931846f6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/testReport/
Max. process+thread count 206 (vs. ulimit of 30000)
modules C: hbase-replication U: hbase-replication
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 0m 16s master passed
+1 💚 checkstyle 0m 8s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 22s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 0m 14s the patch passed
+1 💚 javac 0m 14s the patch passed
+1 💚 checkstyle 0m 6s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 9m 26s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 0m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
24m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5321
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 14538c9af69a 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b2e2abe
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-replication U: hbase-replication
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5321/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj
2005hithlj approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@2005hithlj 2005hithlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9 Apache9 merged commit 1d704a7 into apache:master Jul 11, 2023
Apache9 added a commit that referenced this pull request Jul 11, 2023
@Apache9
HBASE-27969 TableReplicationQueueStorage.hasData does not work as exp…
cb0540c 
…ected (#5321)

Signed-off-by: Liangjun He <heliangjun@apache.org>
(cherry picked from commit 1d704a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2005hithlj 2005hithlj 2005hithlj approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @2005hithlj